Question

我的代码有问题。如何处理从服务到我的gsp的错误？我尝试使用来自服务或控制器的渲染，但是类似 [属[{0}]类[{1}]的值[{2}]不是有效的电子邮件地址] 并获得错误500：内部服务器错误，并带有完整的异常跟踪。我的消息来源：

UserController.groovy

def saveUser() {

    def salt = new SecureRandomNumberGenerator().nextBytes().getBytes()
    def user

    try {
        user = userService.registerMethod(params.username, params.passwordHash, params.passwordHash2,
            salt, params.firstName, params.lastName, params.sex, params.email, params.mobile, params.userType)

        session.user = user
        flash.message = "User ${user.profile.firstName} ${user.profile.lastName} was successfuly created!"
        redirect(uri:"/")
    } catch (UserRegistrationException ure) {
        user = ure.user
        if (user) {
            render(view:"registration",model:[user:user])
        } else {
            flash.message = ure.message
            redirect(action:"registration")
        }
    }

}

UserService.groovy

class UserRegistrationException extends RuntimeException {
String message
User user
}

class UserService {

boolean transactional = true

User registerMethod(String username, String password1, String password2, Object salt, String firstName, String lastName,
        String sex, String email, String mobile, String userType) {

    def user = User.findByUsername(username)
    if(user) {
        //flash.message = "User already exists with login ${username}"
        throw new UserRegistrationException(message:"User already exists with login ${username}")
        redirect(uri:"/")
    } else {
        if (password1 != password2) {
            //flash.message = "Passwords don't match"
            throw new UserRegistrationException(message:"Passwords don't match")
        } else {
            def profile = Profile.findByEmail(email)
            if (profile && (email == profile.email)) {
                //flash.message = "User with this email is already exists!"
                throw new UserRegistrationException(message:"User with this email is already exists!")
            } else {
                user = new User(
                    username:username,
                    passwordHash: new Sha512Hash(password1, salt, 1024).toHex(),
                    passwordSalt:salt,
                    profile: new Profile(
                        firstName:firstName,
                        lastName:lastName,
                        sex:sex,
                        email:email,
                        mobile:mobile,
                        userType:userType
                        )
                    )

                if (!user.hasErrors() && user.save(flush:true,failOnError:true)) {
                    def authToken = new UsernamePasswordToken(username, password1)
                    SecurityUtils.subject.login(authToken)
                    return user
                } else {
                    throw new UserRegistrationException(message:"Can't create user");
                }
            }
        }
    }
}

}

registration.gsp

<body>
    <h1>Registration Page</h1>

    <g:if test="${ flash.message }">
        ${ flash.message }
    </g:if>
    <g:hasErrors bean="${ user }">
        <g:renderErrors bean="${ user }" as="list"/>
    </g:hasErrors>

    <div id="registration">
        <g:form action="saveUser">
        <table>
            <tr>
                <td><label for="username">Login: </label></td>
                <td><g:textField name="username" id="username" /></td>
            </tr>
            <tr>
                <td><label for="firstName">First Name: </label></td>
                <td><g:textField name="firstName" id="firstName"/></td>
            </tr>
            <tr>
                <td><label for="lastName">Last Name: </label></td>
                <td><g:textField name="lastName" id="lastName"/></td>
            </tr>
            <tr>
                <td><label for="sex">Sex: </label></td>
                <td><g:radioGroup values="['M','F']" name="sex" labels="['Male','Female']">
                <p>${ it.radio } ${ it.label }</p>
                </g:radioGroup></td>
            </tr>
            <tr>
                <td><label for="email">Email: </label></td>
                <td><g:textField name="email" id="email"/></td>
            </tr>
            <tr>
                <td><label for="mobile">Mobile: </label></td>
                <td><g:textField name="mobile" id="mobile"/></td>
            </tr>
            <tr>
                <td><label for="passwordHash">Password: </label></td>
                <td><g:passwordField name="passwordHash" id="passwordHash"/></td>
            </tr>
            <tr>
                <td><label for="passwordHash2">Confirm password: </label></td>
                <td><g:passwordField name="passwordHash2" name="passwordHash2" id="passwordHash2" /></td>
            </tr>
            <tr>
                <td><label for="userType">User Type: </label></td>
                <td>
                    <g:radioGroup values="['F','H']" name="userType" labels="['Freelancer','Client']">
                        <p>${ it.radio } ${ it.label }</p>
                    </g:radioGroup>
                </td>
            </tr>
            <tr>
                <td><g:submitButton name="saveUser" value="Register"/> </td>
            </tr>
        </table>
        </g:form>
    </div>

</body>

我的代码可能有问题吗？

我想向用户显示错误，但不是完整的异常跟踪

Answer 1

您正在使用save(failOnError:true)，这会在您的保存失败时引发异常。由于您只捕获UserRegistrationException，因此save()的异常产生500内部服务器错误。您可以删除failOnError，并且您的服务方法应该落到throw new UserRegistrationException块，并按照您的预期行事。

Answer 2

我只是想补充说，使用Exception控制流程并不是很好的程序设计而且非常昂贵。我建议删除UserRegistrationException，而只返回一个布尔false并在控制器中检查它。请记住，groovy方法是动态输入的，您可以返回任何想要的内容。

处理grails中的服务错误

2 个答案: