从Finalizer调用托管资源安全吗? (如果我检查null)

时间:2012-07-06 14:01:02

标签: c# dispose finalizer

打电话不安全:

component.Dispose(); (如果我检查空)

如果我将代码改为此,则从Finalizer

~MyResource()
{
    Dispose();
}
public void Dispose()
{
 // Check to see if Dispose has already been called.
        if(!this.disposed)
        {
            if(component != null) component.Dispose();   // !!! //

            CloseHandle(handle);
            handle = IntPtr.Zero;

            disposed = true;

        }
    GC.SuppressFinalize(this);
}

我知道这有效 - 但它安全吗?

(来自下面的例子?)

代码示例:(在更改代码之前)

http://msdn.microsoft.com/en-us/library/system.idisposable.dispose.aspx

using System;
using System.ComponentModel;

// The following example demonstrates how to create
// a resource class that implements the IDisposable interface
// and the IDisposable.Dispose method.

public class DisposeExample
{
// A base class that implements IDisposable.
// By implementing IDisposable, you are announcing that
// instances of this type allocate scarce resources.
public class MyResource: IDisposable
{
    // Pointer to an external unmanaged resource.
    private IntPtr handle;
    // Other managed resource this class uses.
    private Component component = new Component();
    // Track whether Dispose has been called.
    private bool disposed = false;

    // The class constructor.
    public MyResource(IntPtr handle)
    {
        this.handle = handle;
    }

    // Implement IDisposable.
    // Do not make this method virtual.
    // A derived class should not be able to override this method.
    public void Dispose()
    {
        Dispose(true);
        // This object will be cleaned up by the Dispose method.
        // Therefore, you should call GC.SupressFinalize to
        // take this object off the finalization queue
        // and prevent finalization code for this object
        // from executing a second time.
        GC.SuppressFinalize(this);
    }

    // Dispose(bool disposing) executes in two distinct scenarios.
    // If disposing equals true, the method has been called directly
    // or indirectly by a user's code. Managed and unmanaged resources
    // can be disposed.
    // If disposing equals false, the method has been called by the
    // runtime from inside the finalizer and you should not reference
    // other objects. Only unmanaged resources can be disposed.
    protected virtual void Dispose(bool disposing)
    {
        // Check to see if Dispose has already been called.
        if(!this.disposed)
        {
            // If disposing equals true, dispose all managed
            // and unmanaged resources.
            if(disposing)
            {
                // Dispose managed resources.
                component.Dispose();
            }

            // Call the appropriate methods to clean up
            // unmanaged resources here.
            // If disposing is false,
            // only the following code is executed.
            CloseHandle(handle);
            handle = IntPtr.Zero;

            // Note disposing has been done.
            disposed = true;

        }
    }

    // Use interop to call the method necessary
    // to clean up the unmanaged resource.
    [System.Runtime.InteropServices.DllImport("Kernel32")]
    private extern static Boolean CloseHandle(IntPtr handle);

    // Use C# destructor syntax for finalization code.
    // This destructor will run only if the Dispose method
    // does not get called.
    // It gives your base class the opportunity to finalize.
    // Do not provide destructors in types derived from this class.
    ~MyResource()
    {
        // Do not re-create Dispose clean-up code here.
        // Calling Dispose(false) is optimal in terms of
        // readability and maintainability.
        Dispose(false);
    }
  }
  public static void Main()
  {
    // Insert code here to create
    // and use the MyResource object.
  }
}

2 个答案:

答案 0 :(得分:3)

如果不了解“组件”的实现细节,很难确定是否安全。对象的终结是无序的,并且不遵守包含层次结构,因此虽然“组件”实例可能不是null,但是当您在其上调用Dispose时,它可能已经完成。 Dispose方法通常不会考虑到这种类型的安全性,因为它们只希望在对象最终确定之前被调用。

在你甚至想要考虑做一些聪明的事情,比如在终结者中触摸其他物体之前,请阅读关于这个主题的Chris Brumme's blog帖子; this one is a good starting point

通常,除非在非常特定的情况下,并且您知道所包含对象的Dispose方法即使在最终确定时被调用也会按预期运行,我假设您询问的模式不是安全并且会坚持使用推荐的传递bool disposing参数的模式,并且只有在true时才触及托管对象。

答案 1 :(得分:2)

在.net中,保证存在任何可通过任何方式访问的对象,可以访问此类对象的字段,并且可以调度该对象上的属性访问或方法调用,就像在任何其他情况下一样。唯一不能保证的是系统是否已经在引用的对象上运行Finalize方法。完全有可能的是,由于系统已经在对象上运行Finalize,之前已经完成某些有用的方法将不再能够这样做,但这是对象{{{ 1}}例程,与垃圾收集器本身无关。