Rails Hash.from_xml没有给出预期的结果

时间:2013-02-15 09:45:38

标签: ruby-on-rails ruby xml nokogiri

尝试处理来自名为TeleForm的应用程序的某些XML。这是表单扫描软件,它抓取数据并将其放入XML中。这是XML的片段

<?xml version="1.0" encoding="ISO-8859-1"?>
<Records>
  <Record>
    <Field id="ImageFilename" type="string" length="14"><Value>00000022000000</Value></Field>
    <Field id="Criterion_1" type="number" length="2"><Value>3</Value></Field>
    <Field id="Withdrew" type="string" length="1"></Field>
  </Record>

  <Record>
    <Field id="ImageFilename" type="string" length="14"><Value>00000022000001</Value></Field>
    <Field id="Criterion_1" type="number" length="2"><Value>3</Value></Field>
    <Field id="Withdrew" type="string" length="1"></Field>
  </Record>
</Records>

我在其他系统中处理过这个问题,可能使用了我们编写的自定义解析器。我认为在Rails中没问题,但我错了。

用Hash.from_xml或Nokogiri解析这个并没有给我我预期的结果,我得到:

{"Records"=>{"Record"=>[{"Field"=>["", {"id"=>"Criterion_1", "type"=>"number", "length"=>"2", "Value"=>"3"}, ""]},
 {"Field"=>["", {"id"=>"Criterion_1", "type"=>"number", "length"=>"2", "Value"=>"3"}, ""]}]}}

在花了太多时间之后,我发现如果我详细说明了类型和长度属性,我得到了我的预期(即使它是错的!我只在第一个记录节点上删除了。)

{"Records"=>{"Record"=>[{"Field"=>[{"id"=>"ImageFilename", "Value"=>"00000022000000"}, 
{"id"=>"Criterion_1", "type"=>"number", "length"=>"2", "Value"=>"3"}, {"id"=>"Withdrew"}]}, 
{"Field"=>["", {"id"=>"Criterion_1", "type"=>"number", "length"=>"2", "Value"=>"3"}, ""]}]}}

不熟悉XML,我假设使用类型和长度属性的这种XML风格试图转换为数据类型。在这种情况下,我可以理解为什么“Withdrew”属性显示为空,但不明白为什么“ImageFilename”为空 - 它是一个14个字符的字符串。

我已经开始使用gsub,但这是无效的XML吗?添加DTD(TeleForm应该提供的)会给我不同的结果吗?

修改

我会用一些代码作为编辑,为我自己的问题提供一个可能的答案。该代码遵循我从Mark Thomas收到的一个答案中的一些功能,但我决定反对Nokogiri,原因如下:

  • xml是一致的,并且总是包含相同的标签(/ Records / Record / Field)和属性。
  • 每个XML文件中可以有几百条记录,Nokogiri似乎有点慢,只有26条记录
  • 我想出了如何让Hash.from_xml给我我所期望的(不喜欢type =“string”,但只使用哈希来填充一个类。

带有一个完整记录的XML的扩展版本

<?xml version="1.0" encoding="ISO-8859-1"?>
<Records>
  <Record>
    <Field id="ImageFilename" type="string" length="14"><Value>00000022000000</Value></Field>
    <Field id="DocID" type="string" length="15"><Value>731192AIINSC</Value></Field>
    <Field id="FormID" type="string" length="6"><Value>AIINSC</Value></Field>
    <Field id="Availability" type="string" length="18"><Value>M  T  W  H  F  S</Value></Field>
    <Field id="Criterion_1" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_2" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_3" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_4" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_5" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_6" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_7" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_8" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_9" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_10" type="number" length="2"><Value>3</Value></Field>
    <Field id="Criterion_11" type="number" length="2"><Value>0</Value></Field>
    <Field id="Criterion_12" type="number" length="2"><Value>0</Value></Field>
    <Field id="Criterion_13" type="number" length="2"><Value>0</Value></Field>
    <Field id="Criterion_14" type="number" length="2"><Value>0</Value></Field>
    <Field id="Criterion_15" type="number" length="2"><Value>0</Value></Field>
    <Field id="DayTraining" type="string" length="1"><Value>Y</Value></Field>
    <Field id="SaturdayTraining" type="string" length="1"></Field>
    <Field id="CitizenStageID" type="string" length="12"><Value>731192</Value></Field>
    <Field id="NoShow" type="string" length="1"></Field>
    <Field id="NightTraining" type="string" length="1"></Field>
    <Field id="Withdrew" type="string" length="1"></Field>
    <Field id="JobStageID" type="string" length="12"><Value>2292</Value></Field>
    <Field id="DirectHire" type="string" length="1"></Field>
  </Record>
</Records>

我只是尝试使用工作流原型来替换用4D和Active4D编写的老化系统。处理TeleForms数据的这个区域是作为批处理操作实现的,它仍然可以恢复到那个。我只是想在新的Rails实现中合并一些旧的可行概念。 XML文件位于共享服务器上,可能必须移动到Web根目录,然后将一些触发器设置为处理文件。

我仍然处于定义阶段,但我处理InterviewForm的模块/类看起来像这样并且可能会发生变化(几乎没有错误捕获,仍然试图进入测试阶段,而且我的Ruby并不像它应该的那么好在玩Rails大约5年之后!):

module Teleform::InterviewForm

  class Form < Prawn::Document
    # Not relevant to this question, but this class generates the forms from a Fillable PDF template and 
    # relavant Model(s) data.
    # These forms, when completed are what is processsed by TeleForms and produces the xml.
  end

  class RateForms
    attr_accessor  :records, :results

    def initialize(xml_path)
      fields = []
      xml = File.read(xml_path)
      # Hash.from_xml does not like a type of "string"
      hash = Hash.from_xml(xml.gsub(/type="string"/,'type="text"'))
      hash["Records"]["Record"].each do |record|
        #extract the field form each record
        fields << record["Field"]
      end
      @records = []
      fields.each do |field|
        #build the records for the form
        @records << Record.new(field)
      end
      @results = rate_records
    end

    def rate_records
      # not relevant to the qustions but this is where the data is processed and a bunch of stuff takes place
      return "Any errors"
    end
  end


  class Record
    attr_accessor(*[:image_filename, :doc_id, :form_id, :availability, :criterion_1, :criterion_2, 
      :criterion_3, :criterion_4, :criterion_5, :criterion_6, :criterion_7, :criterion_8, 
      :criterion_9, :criterion_10, :criterion_11, :criterion_12, :criterion_13, :criterion_14, :criterion_15, 
      :day_training, :saturday_training, :citizen_stage_id, :no_show, :night_training, :withdrew, :job_stage_id, :direct_hire])

    def initialize(fields)
      fields.each do |field|
        if field["type"] == "number"
          try("#{field["id"].underscore.to_sym}=", field["Value"].to_i)
        else
          try("#{field["id"].underscore.to_sym}=", field["Value"])
        end
      end
    end
  end

end

2 个答案:

答案 0 :(得分:0)

感谢您添加额外信息,这是对受访者的评分。在代码中使用此域信息可能会改进它。您尚未发布任何代码,但通常使用域对象可以使代码更简洁,更易读。 我建议创建一个表示Rating的简单类,而不是将数据从XML转换为数据结构。

class Rating
  attr_accessor :image_filename, :criterion_1, :withdrew
end

使用上面的类,这是使用Nokogiri从XML中提取字段的一种方法。

doc = Nokogiri::XML(xml)
ratings = []

doc.xpath('//Record').each do |record|
    rating = Rating.new
    rating.image_filename = record.at('Field[@id="ImageFilename"]/Value/text()').to_s
    rating.criterion_1 = record.at('Field[@id="Criterion_1"]/Value/text()').to_s
    rating.withdrew = record.at('Field[@id="Withdrew"]/Value/text()').to_s
    ratings << rating
end

现在,ratingsRating个对象的列表,每个对象都有检索数据的方法。这比钻研深层数据结构要简洁得多。您甚至可以进一步改进Rating类,例如创建一个返回true或false的withdrew?方法。

答案 1 :(得分:0)

似乎'XmlSimple'(由maik)[https://github.com/maik/xml-simple]更适合此任务,然后是不可靠且不一致的Hash.from_xml实现。

经过试验和测试的同名perl模块的端口,它具有几个显着的优点。

  • 无论您发现一个或多个节点
  • ,都是一致的
  • 不会扼杀和混淆结果
  • 能够区分属性和节点内容。

通过解析器运行上述相同的xml文档:

XmlSimple.xml_in xml

将产生以下结果。

{"Record"=>
  [{"Field"=>
     [{"id"=>"ImageFilename", "type"=>"string", "length"=>"14", "Value"=>["00000022000000"]},
      {"id"=>"DocID", "type"=>"string", "length"=>"15", "Value"=>["731192AIINSC"]},
      {"id"=>"FormID", "type"=>"string", "length"=>"6", "Value"=>["AIINSC"]},
      {"id"=>"Availability", "type"=>"string", "length"=>"18", "Value"=>["M  T  W  H  F  S"]},
      {"id"=>"Criterion_1", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_2", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_3", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_4", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_5", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_6", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_7", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_8", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_9", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_10", "type"=>"number", "length"=>"2", "Value"=>["3"]},
      {"id"=>"Criterion_11", "type"=>"number", "length"=>"2", "Value"=>["0"]},
      {"id"=>"Criterion_12", "type"=>"number", "length"=>"2", "Value"=>["0"]},
      {"id"=>"Criterion_13", "type"=>"number", "length"=>"2", "Value"=>["0"]},
      {"id"=>"Criterion_14", "type"=>"number", "length"=>"2", "Value"=>["0"]},
      {"id"=>"Criterion_15", "type"=>"number", "length"=>"2", "Value"=>["0"]},
      {"id"=>"DayTraining", "type"=>"string", "length"=>"1", "Value"=>["Y"]},
      {"id"=>"SaturdayTraining", "type"=>"string", "length"=>"1"},
      {"id"=>"CitizenStageID", "type"=>"string", "length"=>"12", "Value"=>["731192"]},
      {"id"=>"NoShow", "type"=>"string", "length"=>"1"},
      {"id"=>"NightTraining", "type"=>"string", "length"=>"1"},
      {"id"=>"Withdrew", "type"=>"string", "length"=>"1"},
      {"id"=>"JobStageID", "type"=>"string", "lth"=>"12", "Value"=>["2292"]},
      {"id"=>"DirectHire", "type"=>"string", "length"=>"1"}]
  }]
}

我正在考虑修复问题并为Hash提供from_xml的工作实现,并希望从其他人那里得到一些得出相同结论的反馈。当然,我们并不是唯一有这些挫折感的人。

与此同时,我们可能会因为知道有比Nokogiri更轻的东西及其完整的厨房水槽而感到安慰。

的nJoy!

相关问题