未在Task.Factory.StartNew()中创建日志文件

时间:2013-07-04 11:21:57

标签: c# c#-4.0 task-parallel-library

对于以下示例代码,我没有看到日志文件" ParallelLog.txt"在C:驱动器中创建。 (为大块代码道歉!)

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Threading;
using System.IO;

namespace Logger
{
    internal class Program
    {
        static List<Employee> employees = new List<Employee>()
        {
            new Employee{Name = "William", Age=30, RollNo=1234},
            new Employee{Name = "Martin", Age=29, RollNo=1235},
            new Employee{Name = "Richard", Age=28, RollNo=1236},
            new Employee{Name = "Baldwin", Age=27, RollNo=1237}
        };

        static void Main(string[] args)
        {
            Task task = Task.Factory.StartNew(() =>
            {
                foreach (Employee employee in employees.AsParallel().AsOrdered())
                {
                    WriteToLog(employee);
                }
            });
        }

        public static void WriteToLog(Employee employee)
        {            
            static string fileName = @"C:\ParallelLog.txt";
            private static object lockObject = new object();

            lock (lockObject)
            {
                StreamWriter writer = new StreamWriter(fileName, true);
                writer.WriteLine("{0} - {1} - {2}", employee.Name, employee.Age, employee.RollNo);
                writer.Close();
                writer.Dispose();
                writer = null;
            }
        }
    }

    internal class Employee
    {
        public int Age { get; set; }
        public string Name { get; set; }
        public int RollNo { get; set; }
    } 
}

我的代码上面有什么问题吗?此示例是我实际项目的日志文件创建过程的基础。

1 个答案:

答案 0 :(得分:2)

尝试以下代码

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Threading;
using System.IO;

namespace Logger
{
    internal class Program
    {
        static List<Employee> employees = new List<Employee>()
        {
            new Employee{Name = "William", Age=30, RollNo=1234},
            new Employee{Name = "Martin", Age=29, RollNo=1235},
            new Employee{Name = "Richard", Age=28, RollNo=1236},
            new Employee{Name = "Baldwin", Age=27, RollNo=1237}
        };

        static void Main(string[] args)
        {
            Task task = Task.Factory.StartNew(() =>
            {
                WriteToLog();
            });
        }

        public static void WriteToLog()
        {            
            static string fileName = @"C:\ParallelLog.txt";
            using (StreamWriter writer = new StreamWriter(fileName, true))
            {
                foreach (Employee employee in employees.AsParallel().AsOrdered())
                    writer.WriteLine("{0} - {1} - {2}", employee.Name, employee.Age, employee.RollNo);
            }
        }
    }

    internal class Employee
    {
        public int Age { get; set; }
        public string Name { get; set; }
        public int RollNo { get; set; }
    } 
}

在这种情况下,不需要使用lock。这将删除StreamWriter对象的连续实例化为一个。在这里,您不必担心管理,因为这是由using关键字处理的。有关使用StreamWriter课程的推荐方法,请参阅MSDN

我希望这会有所帮助。