为什么我无法从此阵列中正确删除项目?

时间:2014-11-26 22:03:00

标签: java arrays

当我删除一个项目时,我将其从数组中删除,然后我打印一条消息,表明它已被删除。

我知道由于数组没有排序,删除项目的最简单方法就是移动当前最后一项,然后减少项目数。

我做错了什么?我该如何解决?

public static int removeBall(String[] hookPotentialArray, String[] nameBallArray, int[] ballWeightArray, int count) {
    Scanner keyboard = new Scanner(System.in);
    System.out.println("Please enter the name of the ball you would like to remove: ");
    String name = keyboard.nextLine();
    boolean ballRemoval = false;
    for (int i = 0; i < count; i++) {
        if (name.compareToIgnoreCase(nameBallArray[i]) == 0 && !ballRemoval) {

            nameBallArray[i] = nameBallArray[count - 1];
            ballWeightArray[i] = ballWeightArray[count - 1];
            hookPotentialArray[i] = hookPotentialArray[count - 1];

            ballRemoval = true;
            count--;

            System.out.println("The ball you selected to be removed "
                    + "has been removed.");
            System.out.println("");
        }
    }
    return count;
}

2 个答案:

答案 0 :(得分:1)

最好创建一个Ball类来存储名称,权重和钩子潜在值,并使用List来存储Ball个对象。 List也有自己的方法来添加和删除项目。

答案 1 :(得分:1)

(1)你应该使用break来退出搜索

(2)您应该在删除最后一项时添加特殊检查

(3)你应该记住,java数组实际上不会缩小,所以你需要保持计数始终正确并且在使用中

如下:

package tests.StackOverflow;

public class q27159679 {

    public static void main(String[] args) {

        String[] hookPotentialArray = {"alpha", "beta", "gamma", "delta"}; 

        String[] nameBallArray = {"A", "B", "C", "D"}; 

        int[] ballWeightArray = {11, 12, 13, 14};

        int count = hookPotentialArray.length;

        printBalls(nameBallArray, count);

        count = removeBall(hookPotentialArray, nameBallArray, ballWeightArray, count, "B");

        count = removeBall(hookPotentialArray, nameBallArray, ballWeightArray, count, "D");


    }


    public static int removeBall(String[] hookPotentialArray, String[] nameBallArray, int[] ballWeightArray, int count, String name) {

        System.out.println("Removing ball " + name);

        for (int i = 0; i < count; i++) {
            if (name.compareToIgnoreCase(nameBallArray[i]) == 0 ) {

                if( i < count - 1) {
                    nameBallArray[i] = nameBallArray[count - 1];
                    ballWeightArray[i] = ballWeightArray[count - 1];
                    hookPotentialArray[i] = hookPotentialArray[count - 1];
                }

                count--;

                System.out.println("The ball you selected to be removed "
                        + "has been removed.");
                printBalls(nameBallArray, count);
                System.out.println("");

                break;
            }
        }
        return count;
    }

    public static void printBalls(String[] nameBallArray, int count) {
        System.out.print("The remaining balls: ");
        for(int i=0; i<count; ++i) {
            System.out.print(nameBallArray[i] + " ");
        }
        System.out.println("");
    }



}
相关问题