Java迭代器无限循环

时间:2015-01-05 04:46:41

标签: java list loops iterator iteration

无法弄清楚为什么这会无限循环。

public void DLCCheck(IconSet iconSet) {
    Log.d(TAG, "Got dlc check. Looking to see if we need to remove any notes from the current list.");
    int foundCount = 0;
    for(Iterator<Item> i = mItemList.iterator(); i.hasNext(); ) {
         if(i instanceof NoteItem && ((NoteItem) i).getIconSet() == iconSet) {
             i.remove();
             foundCount++;
         }
    }
    Log.d(TAG, "Finished searching. Found " + foundCount + "notes in the current list to delete.");
    //notifyDataSetChanged();
    //EventBus.getDefault().post(new MoveNoteListOut());
}

当hasNext返回false时,这不应该停止迭代吗?此列表中只有6个项目,但它会永远循环。

1 个答案:

答案 0 :(得分:11)

你永远不会打电话给i.next()。此外,iinstanceof Iterator,因此i instanceof NoteItem永远不会是true。您应该阅读i.next()中的数据并根据您的条件评估此元素。

这应该是代码:

for(Iterator<Item> i = mItemList.iterator(); i.hasNext(); ) {
     Item item = i.next();
     if(item instanceof NoteItem && ((NoteItem) item).getIconSet() == iconSet) {
                                 //here ---------------------------^^
                                 //not sure what type returns getIconSet
                                 //but if it's not a primitive then you should use equals
         i.remove();
         foundCount++;
     }
}