使用qsort对字符串进行排序不起作用

时间:2015-04-02 20:36:27

标签: c++ c qsort

我有一个程序,它会询问几个字符串并对它们进行排序。 我的代码是:

#include <stdlib.h>
#include <stdio.h>
#include <string.h>

#define MAX_STR_LEN 256

int myStrCmp (const void * a, const void * b)
{
    return strcmp((const char *)a, (const char *)b);
}

int main(void) 
{
    int strNum; // expected number of input strings
    int strCnt; // counter of strings
    char ** storage; // pointr to the memory when strings are stored
    char strBuf[ MAX_STR_LEN]; // buffer for strings
    char * strPtr; 
    // input of strings number
    do{
        printf("How many strings will be entered: ");
        while( scanf("%d", &strNum) != 1)
        {
            printf("ERROR: Not number was entered!\n");
            while( getchar() != '\n' );
            printf("Please enter a number: ");
        }
        if( strNum < 2 )
        {
            printf("ERROR: Number less than 2 was entered!\n");
        }
        while( getchar() != '\n' );
    }
    while(strNum < 2);
    // allocation of memory for pointers
    storage = (char **) calloc(strNum, sizeof(char*) );
    if( storage == NULL )
    {
        printf("ERROR: Unexpected problems with memory allocation!\n");
        return 1;
    }
    // input of strings
    for( strCnt = 0; strCnt < strNum; strCnt++)
    {
        printf("Enter string #%d:\n", strCnt + 1);
        fgets(strBuf,  MAX_STR_LEN, stdin);
        strPtr = strchr(strBuf, '\n');
        if( strPtr )
        {
            *strPtr = '\0';
        }
        else
        {
            strBuf[ MAX_STR_LEN - 1] = '\0';
        }
        // allocation memory for particular string
        storage[strCnt] = (char *) malloc(strlen(strBuf) + 1);
        if(storage[strCnt] == NULL)
        {
            printf("ERROR: Unexpected problems with memory allocation!\n");
            return 2;
        }
        // move string to dynamic memory 
        strcpy(storage[strCnt], strBuf);
    }
    // sort the strings
    qsort(storage, strNum, sizeof(char**), myStrCmp);
    // output the result
    printf("\nSorted strings:\n");
    for( strCnt = 0; strCnt < strNum; strCnt++)
    {
        printf("%s\n", storage[strCnt]);
    }
    return 0;
}

最简单的测试显示了麻烦:

How many strings will be entered: 3
Enter string #1:
ddd
Enter string #2:
aaa
Enter string #3:
ccc

Sorted strings:
ddd
aaa
ccc

我尝试过Visual C ++和gcc,但结果是一样的。请告诉我代码中有什么问题?

1 个答案:

答案 0 :(得分:4)

问题出在myStrCmp函数中。

因为ab不是简单数组中的元素,而是指针数组中的元素,它们的类型必须是char **,并且比较两个元素的函数必须如下所示:

int myStrCmp (const void * a, const void * b)
{
    return strcmp(*(const char **)a, *(const char **)b);
}