使用`SessionFactory`的Hibernate问题

时间:2015-04-06 05:08:53

标签: java multithreading hibernate servlets sessionfactory

我正在使用一个JSP,Servlet(Pure JSP,Servlet)应用程序,它使用Hibernate。下面是一个表的Hibernate实现类。

DesignationImpl.java

package dao;

import model.sub.DesigAllBean;
import java.util.List;
import model.main.Designation;
import org.hibernate.Query;
import org.hibernate.SQLQuery;
import org.hibernate.Session;
import org.hibernate.SessionFactory;
import org.hibernate.Transaction;
import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
import org.hibernate.cfg.Configuration;

/**
 *
 * @author Yohan
 */
public class DesignationImpl implements DesignationInterface
{


    @Override
    public Session openCurrentSession() {
            Session currentSession = getSessionFactory().openSession();
            return currentSession;
    }

    @Override
    public Transaction openTransaction(Session session) {
        Transaction beginTransaction = session.beginTransaction();
        return beginTransaction;
    }

    private static SessionFactory getSessionFactory() {

        Configuration configuration = new Configuration().configure();
        StandardServiceRegistryBuilder builder = new StandardServiceRegistryBuilder()
                        .applySettings(configuration.getProperties());
        SessionFactory sessionFactory = configuration.buildSessionFactory(builder.build());
        return sessionFactory;
    }

    @Override
    public void save(Designation d, Session session)
    {
        session.save(d);
    }

    @Override
    public void update(Designation d, Session session) 
    {
        session.update(d);
    }
}

以下是调用上述类的服务类。

DesignationService .java

package service;

import dao.Common;
import model.sub.*;
import dao.DesignationImpl;
import dao.DesignationInterface;
import java.util.ArrayList;
import java.util.List;
import model.main.Designation;
import org.hibernate.Session;
import org.hibernate.Transaction;

/**
 *
 * @author Yohan
 */
public class DesignationService 
{
    private DesignationInterface designationInterface;

    public DesignationService()
    {
        designationInterface = new DesignationImpl();
    }

    public Session getSession()
    {
        Session session = designationInterface.openCurrentSession();
        return session;
    }

    public Transaction getTransaction(Session session)
    {
        return designationInterface.openTransaction(session);
    }

    public String save(Designation d)
    {
        Session session = designationInterface.openCurrentSession();
        Transaction transaction = null;
        String result="";

        try
        {
            transaction = designationInterface.openTransaction(session);
            designationInterface.save(d,session);
            transaction.commit();
            result = Common.SAVE_SUCCESS;
        }
        catch(Exception e)
        {
            e.printStackTrace();

            if(transaction!=null)
            {
                transaction.rollback();
            }
            result = Common.SAVE_ROLLBACK;
        }
        finally
        {
            session.close();
        }

        return result;
    }

    public String update(Designation d)
    {
        Session session = designationInterface.openCurrentSession();
        Transaction transaction = null;
        String result="";

        try
        {
            transaction = designationInterface.openTransaction(session);
            designationInterface.update(d,session);
            transaction.commit();
            result = Common.SAVE_SUCCESS;
        }
        catch(Exception e)
        {
            e.printStackTrace();

            if(transaction!=null)
            {
                transaction.rollback();
            }
            result = Common.SAVE_ROLLBACK;
        }
        finally
        {
            session.close();
        }

        return result;
    }
}

servlet会像下面一样调用它们。

DesignationService desigSrvc=new DesignationService();

        Designation designation=desigSrvc.findByForiegnKey(idEmployee);

        Employee empl=new Employee();
        empl.setIdEmployee(idEmployee);

        if(designation.getDateCreated()==null)
        {
            designation.setDateCreated(Common.getCurrentDateSQL());
        }   

        designation.setEmployee(empl);
        designation.setDesignation(txtDesignation);
        designation.setLocation(location);
        designation.setSalary(salary);
        designation.setDatePromoted(datePromoted);
        designation.setLastUpdated(Common.getCurrentDateSQL());       

        desigSrvc.save(designation);

正如您所看到的,那里发生了一件坏事,也就是说,servlet每次执行时都会创建新的SessionFactory实例。我遇到Driver#Connect个问题,我想这可能是原因。

我读过stackoverflow帖子,有些似乎建议整个应用程序只使用一个SessionFactory。如果它合适,那我该怎么办呢?也许创建一个像下面这样的单例类并在我的实现类中使用它?

public class SessionFactoryBuilder
{
    private static SessionFactoryBuilder instance;
    private static SessionFactory sessionFactory;

    private SessionFactoryBuilder()
    {
    }

    private static void buildConfig()
    {
        Configuration configuration = new Configuration().configure();
            StandardServiceRegistryBuilder builder = new StandardServiceRegistryBuilder()
                            .applySettings(configuration.getProperties());
            sessionFactory = configuration.buildSessionFactory(builder.build());
    }

    public static SessionFactoryBuilder getInstance()
    {
         if(instance == null) 
         {
            instance = new SessionFactoryBuilder();
            buildConfig();
         }
      return instance;
    }

    public SessionFactory getSessionFactory()
    {
        return sessionFactory;
    }
}

但那么线程呢? Servlet是多线程的不是吗?

2 个答案:

答案 0 :(得分:2)

正如我评论的那样,我将HibernateUtil.java类作为Singleton。这个类可以使用HibernateUtil.getSessionFactory()为你提供sessionfactory,你应该从你的DesignationImpl类中删除相关的代码

public class HibernateUtil {

private static StandardServiceRegistry serviceRegistry; 
private static SessionFactory INSTANCE = null;
public static SessionFactory getSessionFactory() {
     if(INSTANCE=null){
          createSessionFactory():
      }
      return sessionFactory;
}
private synchronized static void createSessionFactory(){
    if(INSTANCE!=null){return;}
    Configuration configuration = new Configuration();
    configuration.configure();
    SeviceRegistry=newStandardServiceRegistryBuilder().applySettings(configuration.getProperties()).build();
    sessionFactory = configuration.buildSessionFactory(serviceRegistry);
    }
  }
}

找到上面的代码,请建议/评论以确认代码的正确性。我认为线程将使用这个..我添加了一个双重检查,以避免多次会议创建和广泛的资源。

答案 1 :(得分:0)

我更正了Viraj Nalawade的代码,该代码有一些错误:

class HibernateUtil {
    private static SessionFactory INSTANCE = null;

    public static SessionFactory getSessionFactory() {
        if (INSTANCE == null) {
            createSessionFactory();
        }
        return INSTANCE;
    }

    private synchronized static void createSessionFactory() {
        if (INSTANCE != null) {
            return;
        }
        Configuration configuration = new Configuration();
        configuration.configure();
        ServiceRegistry serviceRegistry = configuration.getStandardServiceRegistryBuilder().applySettings(configuration.getProperties()).build();
        INSTANCE = configuration.buildSessionFactory(serviceRegistry);
    }
}
相关问题