验收测试没有重置

时间:2015-07-13 18:14:21

标签: ember.js ember-cli ember-qunit

我有一些测试组件的验收测试。如果我单独运行每个测试,他们通过就好了。但是,当我一起运行测试时,它们会失败,因为它们保留了之前测试的值。

这是我的代码:

过滤器-test.js

module('Integration - Filter', {
  beforeEach: function() {
    App = startApp();
    server = setupPretender();
    authenticateSession();
  },
  afterEach: function() {
    Ember.run(App, 'destroy');
    server.shutdown();
  }
});

test('filters can be saved and selected via the dropdown', function(assert) {
  visit('/status');
  fillIn('.filter-status', 'Not Completed');
  fillIn('.filter-id', '444');

  andThen(function() {
    assert.ok(find('.status-title').text().includes('2 of 7'), 'the new filter filters the results');
  });
});

test('only saved filters can be edited', function(assert) {
  visit('/status');
  fillIn('.filter-id', 'not an id');
  click('.update-filter');

  andThen(function() {
    assert.equal(find('.alert').text(), 'Not a Saved Filter×');
  });
});

test('filter values can be cleared', function(assert) {
  visit('/status');
  fillIn('.filter-id', '444');
  fillIn('.filter-status', 'Completed');
  click('.clear-filters');

  andThen(function() {
    // this fails because `.filter-id` is set to 'not an id':
    assert.equal(find('.filter-id').val(), '', 'filter for was reset to its initial value');
    // this also fails because `.filter-status` is set to 'Not Completed':
    assert.equal(find('.filter-status').val(), 'Everything', 'status dropdown was reset to its initial value');
  });
});

PS-滤波器/ component.js

export default Ember.Component.extend({
  classNames: ['panel', 'panel-default', 'filter-panel'],
  currentFilter: null,
  initialValues: null,

  didInsertElement: function() {
    this.set('initialValues', Ember.copy(this.get('filterValues')));
  },

  actions: {
    saveFilter: function(name) {
      var filters = this._getFilterList();
      var filterValues = this.get('filterValues');

      if (!Ember.isEmpty(name)) {
        filters[name] = filterValues;

        this.sendAction('updateFilter', filters);
        this.set('currentFilter', name);
      }
    },

    updateFilter: function() {
      var filterValues = this.get('filterValues');
      var currentFilter = this.get('currentFilter')
      var filters = this.get('userFilters');

      filters[currentFilter] = filterValues;

      this.sendAction('updateFilter', filters);
    },

    clearFilters: function() {
      this.set('currentFilter', null);
      this.set('filterValues', Ember.copy(this.get('initialValues')));
    }
  }
});

状态/ controller.js

export default Ember.ArrayController.extend({
  filterValues: {
    filterStatus: 'Everything',
    filterId: 'id',
  },
  userFilters: Ember.computed.alias('currentUser.content.preferences.filters')
});

状态/ template.hbs

<div class="row">
  {{ps-filter
    filterValues=filterValues
    userFilters=userFilters
    updateFilter='updateFilter'
  }}
</div>

从我收集的内容来看,它似乎将initialValues设置为上一次测试中剩余的filterValues。但是,我认为afterEach应该将其重置为原始状态。有没有理由不将它重置为控制器中的值?

请注意,在开发中运行组件时,组件正常工作。

Ember Inspector中列出的Ember版本:

Ember      : 1.11.3
Ember Data : 1.0.0-beta.18

我正在运行Ember CLI 0.2.7

修改

我认为这根本不是问题,但这是我的伪装者设置:

测试/助手/设置-pretender.js

export default function setupPretender(attrs) {
  var users = [
    {
      id: 1,
      name: 'ttest',
      preferences: null
    }
  ];

  var activities = [
    {
      id: 36874,
      activity_identifier: '18291',
      status: 'Complete'
    }, {
      id: 36873,
      activity_identifier: '82012',
      status: 'In Progress'
    }, {
      id: 35847,
      activity_identifier: '189190',
      status: 'In Progress'
    }, {
      id: 35858,
      activity_identifier: '189076',
      status: 'Not Started'
    }, {
      id: 382901,
      activity_identifier: '182730',
      status: 'Not Started'
    }, {
      id: 400293,
      activity_identifier: '88392',
      status: 'Complete'
    }, {
      id: 400402,
      activity_identifier: '88547',
      status: 'Complete'
    }
  ];

  return new Pretender(function() {
    this.get('api/v1/users/:id', function(request) {
      var user = users.find(function(user) {
        if (user.id === parseInt(request.params.id, 10)) {
          return user;
        }
      });

      return [200, {"Content-Type": "application/json"}, JSON.stringify({user: user})];
    });

    this.get('api/v1/activities', function(request) {
      return [200, {"Content-Type": "application/json"}, JSON.stringify({
        activities: activities
      })];
    });

    this.put('api/v1/users/:id', function(request) {
      var response = Ember.$.parseJSON(request.requestBody);
      response.user.id = parseInt(request.params.id, 10);

      var oldUser = users.find(function(user) {
        if (user.id === parseInt(request.params.id, 10)) {
          return user;
        }
      });
      var oldUserIndex = users.indexOf(oldUser);

      if (oldUserIndex > -1) {
        users.splice(oldUserIndex, 1);
        users.push(response.user);
      }

      return [200, {"Content-Type": "application/json"}, JSON.stringify(response)];
    });
  });
}

当我运行测试时,它会失败,因为它会将值重置为上一个测试中的值。例如,当我运行'filter values can be cleared'时,.filter-id输入与.filter-id具有相同的'only saved filter can be edited值。如果我将'only saved filters can be edited'中的值更改回'',则会'filter values can be cleared'测试通过。

基本上,组件在首次插入元素时设置initialValues属性。它设置为filterValues属性的副本,因此应将其设置为控制器的filterValues属性,并且不应更改。但是,似乎修改后的filterValues属性会转移到下一个测试,这意味着initialValues在重新渲染时设置为该修改后的属性。因此,测试会重新呈现模板,但会在控制器和组件中保留修改后的值。

我可以通过在控制器中创建initialValues属性并将其传递到组件中来传递测试,但这意味着在控制器中具有重复属性(自filterValues和{{1将具有相同的值)。

我可以修改组件中的用户记录,但我认为我们应该只修改控制器或路由器中的记录。此外,是不是initialValues钩子应该重置应用程序?

0 个答案:

没有答案