Question

我写了一个简单的二进制计算器，我将要开发。一切都适用于一些初步计算，但之后程序崩溃 - “Binary.exe已停止工作”。我认为动态可能有问题在函数“decToBin（）”中分配数组，但我无法发现问题。这是代码：

    #include <iostream>
    #include <math.h>
    #include <string>
    #include <conio.h>

    using namespace std;

    void binToDec()
    {
    string bin;
    cout<<"Binary code: ";
    cin>>bin;

    int powr = 0;
    int num = 0;
    long long sum = 0;


    for(int i=bin.size()-1; i>=0; i--)
    {
        if(bin[i] == '1')
        {
            num = 2;
        }
        else if(bin[i] == '0')
        {
            num = 0 ;
        }
        sum += pow(num,powr);
        cout<<sum<<endl;

        powr++;
    }
    cout<<"Decimal: "<<sum<<endl;

    sum = 0;
    powr = 0;
    num = 0;
}

void decToBin()
{
    int dec = 0;
    cout<<"Decimal number or digit: ";
    cin>>dec;

    int i = 0;
    int *numBin = new int[i];
    while(dec > 0)
    {
        numBin[i] = dec%2;
        dec = dec/2;
        i++;
    }
    cout<<"Binary: ";
    for(int j = i-1; j>=0; j--)
    {
        cout<<numBin[j];
    }
    cout<<"\n";
    i = 0;
    delete [] numBin;
}

int main()
{
    //USER INPUT
    int nav = 0;


    while(true)
    {
        cout<<"\n";
        cout << "1.Binary to decimal:"<<endl;
        cout << "2.Decimal to binary:"<<endl;
        cin>>nav;

        switch(nav)
        {
        case 1:
        {
            binToDec();
            break;
        }
        case 2:
        {
            decToBin();
            break;
        }
        }

    }
    return 0;
}

Answer 1

你的问题：

int *numBin = new int[i]; //i is 0, then you add elements to it

一个简单的解决方案，使用std::vector：

vector<int> numBin;
...
numBin.push_back(dec%2);

现在你根本不用担心动态内存。

由于某种原因简单的程序崩溃

1 个答案: