我可以将哪些内容用作SQL中的内部标识符?

时间:2015-12-17 15:53:04

标签: c# sql-server

首先介绍一下背景:

我开发了一种方法,使用IEnumerableyield以批量或页面的形式从SQL中的表中检索行。当您需要只读访问时它很有用,但是当您需要对基础数据进行更新时也不是很好。

所以我编写了一个接受泛型DataTable的方法,并构建了一个更新语句,然后将其作为表值参数传递给SQL以及整个DataTable

方法如下:

string[] validColumns = SQL_Columns.Split(',');
    foreach(DataColumn column in p_UpdatesTable.Columns)
    {
      if(!validColumns.Contains(column.ColumnName))
      {
        throw new Exception("Column '" + column.ColumnName + "' is not valid for this table");
      }
    }

    //Establish SQL Connection
    using (SqlConnection sqlConnection = new SqlConnection(connectionString))
    {
      sqlConnection.Open();
      StringBuilder commandBuilder = new StringBuilder();
      commandBuilder.Append("UPDATE Table SET ");
      List<string> columnsToUpdate = new List<string>(p_UpdatesTable.Columns.Count);
      foreach(DataColumn column in p_UpdatesTable.Columns)
      {
        if (!column.ColumnName.Equals("UID", StringComparison.InvariantCultureIgnoreCase))
        {
          StringBuilder columnBuilder = new StringBuilder();
          columnBuilder.Append(column.ColumnName);
          columnBuilder.Append(" = U.");
          columnBuilder.Append(column.ColumnName);
          columnsToUpdate.Add(columnBuilder.ToString());
        }
      }
      commandBuilder.Append(string.Join(",", columnsToUpdate.ToArray()));
      commandBuilder.Append(" FROM @UpdateTable AS U WHERE UID = U.UID");
      using (SqlCommand sqlCommand = new SqlCommand(commandBuilder.ToString(), sqlConnection))
      {
        SqlParameter updateTableParameter = sqlCommand.Parameters.Add("UpdateTable", SqlDbType.Structured);
        updateTableParameter.Value = p_UpdatesTable;
        int rowsAffected = sqlCommand.ExecuteNonQuery();
        if(rowsAffected != p_UpdatesTable.Rows.Count)
        {
          throw new Exception("Update command affected " + rowsAffected + " rows out of the " + p_UpdatesTable.Rows.Count + " expected.");
        }
      }
      sqlConnection.Dispose();
    }

然后我构建了这个方法来填充更新表:

private void AddUpdate(ref DataTable p_UpdateTable, string p_ColumnName, long p_uid, object p_value)
{
  if(!StronglyTypedDataset.Columns.Contains(p_ColumnName))
  {
    throw new ArgumentException("Table '" + p_ColumnName + "' does not exist in table", "p_ColumnName");
  }
  if(!p_UpdateTable.Columns.Contains(p_ColumnName))
  {
    DataColumn columnToAdd = p_UpdateTable.Columns.Add(p_ColumnName);
    columnToAdd.DataType = StronglyTypedDataset.Columns.Cast<DataColumn>().Where(c => c.ColumnName.Equals(p_ColumnName)).First().DataType;
  }
  var existingRow = p_UpdateTable.Rows.Cast<DataRow>().Where(r => Convert.ToInt64(r["UID"]) == p_uid).FirstOrDefault();
  if(existingRow != null)
  {
    existingRow[p_ColumnName] = p_value;
  }
  else
  {
    DataRow newRow = p_UpdateTable.NewRow();
    newRow["UID"] = p_uid;
    newRow[p_ColumnName] = p_value;
    p_UpdateTable.Rows.Add(newRow);
  }
}

有几次我需要调用它,所以这比其他任何东西都更方便。

现在问题是:有可能我为一个UID添加了一堆列和值,但对于另一个我可能会添加更多列或不添加现有列的值。这个问题就是更新,因为它会删除已经使用空值的数据库中的任何内容,除非我明确说“make this null”,否则我不想要这样做。

我正在考虑通过提供一个默认值来解决这个问题,然后我可以在更新语句中检查,然后在CASE语句中使用UPDATE检查此值,并使用原始值(所以实质上我可以忽略列名前的“U.”)。问题是该表是通用的,因此可能存在任何内容,并且在实际数据的情况下,某种方式与我的默认值匹配,事情就会破坏。

我应该注意,此更新表将构建为批处理,批处理一次更新,而不是逐行更新。

是否有保证不使用的值,可能是GUID(我知道可能仍然存在冲突)或类似的东西?

示例:

说我的表在一行之后看起来像这样:

      |  UID   | column 1 | column 2 |
row 1 |    1   |   x      |    y     |

在第二行,它看起来像这样:

      |  UID   | column 1 | column 2 | column 3 |
row 1 |    1   |   x      |    y     |    ?     |
row 2 |    2   |   x      |    y     |    z     |

第1行第3列的值永远不会被设置,因此默认为null。当我使用我的更新语句时,即使表中已存在某些内容,SQL也会将该值设置为null,但我不希望它更新该行的字段,因为我没有指定值为了它。

我希望能够将值替换为?而不是默认为null,因此我可以将更新语句更改为UPDATE Table SET Column1 = U.Column1, Column2 = U.Column2, Column3 = CASE WHEN U.Column3 = somevalue THEN Column3 ELSE U.Column3 END FROM @UpdateTable U

2 个答案:

答案 0 :(得分:0)

你可以让自己成为一个Maybe<T>,它可以是T的实际值,在这种情况下,你可以推进更新,或者它可以是一个特殊的非值。它可能看起来像这样:

public sealed class Maybe<T> {
    private readonly T value;
    private readonly bool hasValue;

    private Maybe() {
        hasValue = false;
    }

    public readonly Maybe<T> Nothing = new Maybe();

    public Maybe(T value) {
        this.value = value;
        hasValue = true;
    }

    public T Value {
        get {
            return value;
        }
    }

    public bool HasValue {
        get {
            return value;
        }
    }
}

您可以这样使用:

private void AddUpdate<T>(DataTable p_UpdateTable, string p_ColumnName, long p_uid, Maybe<T> p_value) {
    // ...
    if(existingRow != null) {
        if(p_value.HasValue)
            existingRow[p_ColumnName] = p_value.Value;
    }
    else {
        DataRow newRow = p_UpdateTable.NewRow();
        newRow["UID"] = p_uid;
        if(p_value.HasValue)
            newRow[p_ColumnName] = p_value.Value;
        p_UpdateTable.Rows.Add(newRow);
    }
    // ...
}

顺便说一下,ref参数不需要DataTable

答案 1 :(得分:0)

我采取了略微不同的路线,没有使用标识符,而是完全使用另一列。

我的AddUpdate现在看起来像这样:

private void AddUpdate(DataTable p_UpdateTable, string p_ColumnName, long p_uid, object p_value)
{
  if (!StronglyTypedDataSet.Columns.Contains(p_ColumnName))
  {
    throw new ArgumentException("Table '" + p_ColumnName + "' does not exist in table", "p_ColumnName");
  }
  if (!p_UpdateTable.Columns.Contains(p_ColumnName))
  {
    var matchingColumn = StronglyTypedDataSet.Columns.Cast<DataColumn>().Where(c => c.ColumnName.Equals(p_ColumnName)).First();
    DataColumn columnToAdd = p_UpdateTable.Columns.Add(p_ColumnName, matchingColumn.DataType);
    columnToAdd.MaxLength = matchingColumn.MaxLength;
    DataColumn setNullColumn = p_UpdateTable.Columns.Add(p_ColumnName + "_null", typeof(bool));
    setNullColumn.DefaultValue = false;
  }
  var existingRow = p_UpdateTable.Rows.Cast<DataRow>().Where(r => Convert.ToInt64(r["UID"]) == p_uid).FirstOrDefault();
  if (existingRow != null)
  {
    existingRow[p_ColumnName] = p_value;
    if (p_value == null || p_value == DBNull.Value)
    {
      existingRow[p_ColumnName + "_null"] = true;
    }
  }
  else
  {
    DataRow newRow = p_UpdateTable.NewRow();
    newRow["UID"] = p_uid;
    newRow[p_ColumnName] = p_value;
    if (p_value == null || p_value == DBNull.Value)
    {
      newRow[p_ColumnName + "_null"] = true;
    }
    p_UpdateTable.Rows.Add(newRow);
  }
}

这样,如果列被默认为null,因为只有在将某些行添加到表后才添加,我可以在我的update语句中检查不更新值。

更新语句现在看起来像这样:

string[] validColumns = SQL_Columns.Split(',');
    var trimmed = validColumns.Select(c => c.Trim());
    foreach(DataColumn column in p_UpdatesTable.Columns)
    {
      if(!column.ColumnName.EndsWith("_null") && !trimmed.Contains(column.ColumnName))
      {
        throw new Exception("Column '" + column.ColumnName + "' is not valid for table");
      }
    }
    string tableTypeName = "dbo.UpdateSpecific" + Guid.NewGuid().ToString().Replace("-", "").Replace("{", "").Replace("}", "");
    StringBuilder tableTypeBuilder = new StringBuilder();
    tableTypeBuilder.Append("CREATE TYPE ");
    tableTypeBuilder.Append(tableTypeName);
    tableTypeBuilder.Append(" AS TABLE (");
    List<string> tableTypeColumns = new List<string>(p_UpdatesTable.Columns.Count);

    StringBuilder commandBuilder = new StringBuilder();
    commandBuilder.Append("UPDATE Table SET ");
    List<string> columnsToUpdate = new List<string>(p_UpdatesTable.Columns.Count);
    foreach (DataColumn column in p_UpdatesTable.Columns)
    {
      //build command to create table type
      StringBuilder columnTypeBuilder = new StringBuilder();
      columnTypeBuilder.Append("[");
      columnTypeBuilder.Append(column.ColumnName);
      columnTypeBuilder.Append("] ");
      if(column.DataType == typeof(int))
      {
        columnTypeBuilder.Append("INT");
      }
      else if(column.DataType == typeof(long))
      {
        columnTypeBuilder.Append("BIGINT");
      }
      else if(column.DataType == typeof(bool))
      {
        columnTypeBuilder.Append("BIT");
      }
      else if(column.DataType == typeof(string))
      {
        columnTypeBuilder.Append("VARCHAR(");
        columnTypeBuilder.Append(column.MaxLength);
        columnTypeBuilder.Append(")");
      }
      else if(column.DataType == typeof(byte[]))
      {
        columnTypeBuilder.Append("IMAGE");
      }
      tableTypeColumns.Add(columnTypeBuilder.ToString());

      //build actual update statement
      if (!column.ColumnName.Equals("UID", StringComparison.InvariantCultureIgnoreCase) && !column.ColumnName.EndsWith("_null"))
      {
        StringBuilder columnBuilder = new StringBuilder();
        columnBuilder.Append(column.ColumnName);
        columnBuilder.Append(" = (CASE WHEN U.");
        columnBuilder.Append(column.ColumnName);
        columnBuilder.Append(" IS NULL THEN (CASE WHEN ISNULL(U.");
        columnBuilder.Append(column.ColumnName);
        columnBuilder.Append("_null, 0) = 1 THEN U.");
        columnBuilder.Append(column.ColumnName);
        columnBuilder.Append(" ELSE C.");
        columnBuilder.Append(column.ColumnName);
        columnBuilder.Append(" END) ELSE U.");
        columnBuilder.Append(column.ColumnName);
        columnBuilder.Append(" END)");
        columnsToUpdate.Add(columnBuilder.ToString());
      }
    }
    tableTypeBuilder.Append(string.Join(",", tableTypeColumns.ToArray()));
    tableTypeBuilder.Append(")");

    commandBuilder.Append(string.Join(",", columnsToUpdate.ToArray()));
    commandBuilder.Append(" FROM Table AS C JOIN @UpdateTable AS U ON C.UID = U.UID");

    //Establish SQL Connection
    using (SqlConnection sqlConnection = new SqlConnection(context.strContext[(int)eCCE_Context._CONNECTION_STRING]))
    {
      sqlConnection.Open();
      try
      {
        using (SqlCommand createTableTypeCommand = new SqlCommand(tableTypeBuilder.ToString(), sqlConnection))
        {
          createTableTypeCommand.ExecuteNonQuery();
        }

        using (SqlCommand sqlCommand = new SqlCommand(commandBuilder.ToString(), sqlConnection))
        {
          SqlParameter updateTableParameter = sqlCommand.Parameters.Add("@UpdateTable", SqlDbType.Structured);
          updateTableParameter.Value = p_UpdatesTable;
          updateTableParameter.TypeName = tableTypeName;
          int rowsAffected = sqlCommand.ExecuteNonQuery();
          if (rowsAffected != p_UpdatesTable.Rows.Count)
          {
            throw new Exception("Update command affected " + rowsAffected + " rows out of the " + p_UpdatesTable.Rows.Count + " expected.");
          }
        }
      }
      finally
      {
        string dropStatement = "IF  EXISTS (SELECT * FROM sys.types st JOIN sys.schemas ss ON st.schema_id = ss.schema_id WHERE st.name = N'"+ tableTypeName.Substring(tableTypeName.IndexOf(".")+1) +"' AND ss.name = N'dbo') DROP TYPE " + tableTypeName;
        using (SqlCommand dropTableTypeCommand = new SqlCommand(dropStatement, sqlConnection))
        {
          dropTableTypeCommand.ExecuteNonQuery();
        }
      }
      sqlConnection.Dispose();
    }

经过测试和工作:)