生产者 - 消费者问题:使用条件变量时,posix互斥锁被锁定了两次?

时间:2010-08-09 04:10:36

标签: c multithreading unix posix mutex

以下代码仅用于说明如何使用条件变量将线程(一个生产者和多个消费者)同步为锻炼。 请参阅代码'usleep(100);'的行。当我评论此行时,两个消费者线程似乎在生产者线程退出后同时锁定互斥锁,然后等待'cond',这会引发竞争条件。 但如果我取消注释它。一切顺利(似乎)。

我的问题是两个消费者线程如何同时锁定一个互斥锁?即使我没有打电话给usleep(),这个演示也应该工作?感谢你提前花时间。

这是usleep从生产者的循环中删除后的输出。请注意输出中的最后两个'lock'。

$ ./pthread_cond 
Producer 3062414192 beginning...
Producer locked mutex self:3062414192
Producer is creating work:1
Producer finished creating work:1
Producer unlock self:3062414192
Producer locked mutex self:3062414192
Producer is creating work:2
Producer finished creating work:2
Producer unlock self:3062414192
Producer locked mutex self:3062414192
Producer is creating work:3
Producer finished creating work:3
Producer unlock self:3062414192
Producer locked mutex self:3062414192
Producer is creating work:4
Producer finished creating work:4
Producer unlock self:3062414192
Producer 3062414192 exit after creating 4 works...
produce joined,but 4 work remained
Consumer 3070806896 beginning...
Consumer locked mutex self:3070806896
to wait on cond self:3070806896
Consumer 3079199600 beginning...
Consumer locked mutex self:3079199600
to wait on cond self:3079199600

实现:

#include <pthread.h>
#include <stdio.h>
#include <stdlib.h>
#include <assert.h>

#define MAX_COUSUMER 2

#define TOTAL_WORK 4

int g_work_counter=0;

pthread_mutex_t mut = PTHREAD_MUTEX_INITIALIZER;
pthread_cond_t cond=PTHREAD_COND_INITIALIZER;

void *producer_thread(void* arg)
{
    int i;

    printf("Producer %lu beginning...\n",pthread_self());
    for(i=0;i<TOTAL_WORK;i++)
    {
        assert(pthread_mutex_lock(&mut)==0);
        printf("Producer locked mutex self:%lu\n",pthread_self());
        printf("Producer is creating work:%d\n",g_work_counter+1);
        g_work_counter++;
        printf("Producer finished creating work:%d\n",g_work_counter);
        pthread_cond_broadcast(&cond);
        assert(pthread_mutex_unlock(&mut)==0);
        printf("Producer unlock self:%lu\n",pthread_self());

        //usleep(100);
    }

    printf("Producer self:%lu exit after creating %d works...\n",pthread_self(),i);//counter starts from 0
    pthread_exit(NULL);
}

void *consumer_thread(void *arg)
{
    printf("Consumer %lu beginning...\n",pthread_self());
    //use pthread_cancel in main
    pthread_detach(pthread_self());

    while(1)
    {
        assert(pthread_mutex_lock(&mut)==0);
        printf("Consumer locked mutex self:%lu\n",pthread_self());
        printf("to wait on cond self:%lu\n",pthread_self());
        assert(pthread_cond_wait(&cond,&mut)==0);
        if(g_work_counter)
        {
            printf("Consumer %lu is performing work:%d\n",pthread_self(),g_work_counter);
            g_work_counter--;
            printf("Consumer %lu finished performing work:%d\n",pthread_self(),g_work_counter+1);
        }
        assert(pthread_mutex_unlock(&mut)==0);
        printf("Consumer unlock self:%lu\n",pthread_self());
    }

    //no output (pthread_cancel is called)
    printf("Consumer %lu exit...\n",pthread_self());
    pthread_exit(NULL);
}

int main(int argc,char* argv[])
{
    pthread_t producer;
    pthread_t consumers[MAX_COUSUMER];
    int i;

    for(i=0;i<MAX_COUSUMER;i++)
    {
        if(pthread_create(&consumers[i],NULL,consumer_thread,NULL)!=0)
        {
            printf("pthread_create failed for consumer_thread %d\n",i);
        }
    }

    pthread_create(&producer,NULL,producer_thread,NULL);

    if(pthread_join(producer,NULL)!=0)
    {
        printf("pthread_join failed for producer_thread %lu\n",consumers[i]);
    }
    printf("producer joined,but %d work remained\n",g_work_counter);

    //wait for the consumers
    while(g_work_counter>0)
        ;

    //cancel the consumer,for they are detached
    for(i=0;i<MAX_COUSUMER;i++)
    {
        if(pthread_cancel(consumers[i])!=0)
        {
            printf("pthread_cancel failed for consumer_thread %d\n",i);
        }
    }

    pthread_mutex_destroy(&mut);
    pthread_cond_destroy(&cond);
    return 0;
}

3 个答案:

答案 0 :(得分:3)

当线程等待条件时,释放锁定。当它被唤醒时,它会重新获取它。在此代码中,消费者只应等待缓冲区为空。

另一个问题在于main,实际上,这一行:while(g_work_counter>0)。此时您没有锁,因此检查g_work_counter是不安全的。我对pthread_detach(pthread_self());也不太了解。 main不应该对自己的孩子进行调用吗?

作为一般说明,如果要检查死锁并调试pthreads代码,则应使用pthread_mutexattr_foo函数设置错误检查互斥锁,并检查返回值不仅仅是assert(==0)

答案 1 :(得分:3)

正如Borealid所说,当线程在条件变量上等待时,锁被释放。您的消费者功能应如下所示:

    /* Wait for some work to be available */
    pthread_mutex_lock(&mut);
    while (g_work_counter == 0)
    {
        pthread_cond_wait(&cond, &mut);
    }

    /* Have lock, g_work_counter is > 0, so do work */
    while (g_work_counter > 0)
    {
        g_work_counter--;
    }

    pthread_mutex_unlock(&mut);

pthread_cond_wait()始终在旋转的while循环中使用。)

答案 2 :(得分:1)

我建议你不要使用pthread_cancel()API。很难使用pthread_cancel()而不会引入资源泄漏,死锁和不一致 在你的程序中。

作为重击的规则: 使用分离的线程“一次性/我不关心结果/完成某事”的事情。 对于其他事情,使用“正常线程”,以合作的方式关闭(通过检查 国旗)。

因此,在您的示例中,您希望在退出主程序之前消耗所有工作。 不要将消费者创建为分离并替换取消所有消费者的循环 带有循环的消费者为所有消费者做pthread_join()。