更新CoreData会添加许多nil值

时间:2016-01-31 12:59:46

标签: ios core-data swift2

我正在尝试实现自定义类来处理核心数据操作。它在创建新值时非常有用。但是,当我想更新值时,我在核心数据中得到nil条目。这是我到目前为止的代码

/**
 Update all records in given entity that matches input records
 - parameters:
    - entityName: name of entity to fetch
    - updateBasedOnKey: name of key which will be used to identify entries that are going to be udpated
    - values: NSMutableArray of all elements that are going to be updated
 - important: if object with given updateBasedOnKey doesnt exist it will be created
 - returns: nothing
 */
func updateRecord(entity: String, updateBasedOnKey: String, values: NSMutableArray){
    let entityDescription = NSEntityDescription.entityForName(
        entity, inManagedObjectContext: self.managedObjectContext)
    let results = getRecords(entity)

    for(elements) in values{
        var newEntry = NSManagedObject(entity: entityDescription!, insertIntoManagedObjectContext: self.managedObjectContext)
        //Determine whether to add new result or update existing
        if(results.count > 0){
            for result in results{
                let entry = result as! NSManagedObject
                if let keyValueToCompare = entry.valueForKey(updateBasedOnKey){
                    if (keyValueToCompare.isEqual(elements.valueForKey(updateBasedOnKey)) ){
                        //asign newEntry to result if found in entries
                        newEntry = entry
                    }
                }
            }
        }
        //update entry with new values
        for(key, value) in elements as! NSMutableDictionary{
            newEntry.setValue(value, forKey: key as! String)
        }
        //Try to save resulting entry
        do {
            try newEntry.managedObjectContext?.save()
        } catch {
            print(error)
        }
    }
}

/**
 Fetch all records of given Entity in Core Data Model
 - parameters:
    - entityName: name of entity to fetch
 - returns: NSArray of all records in given entity
 */
func getRecords(entity:String) -> NSArray{
    let entityDescription = NSEntityDescription.entityForName(entity, inManagedObjectContext: self.managedObjectContext)
    let fetchRequest = NSFetchRequest()
    fetchRequest.entity = entityDescription

    var result = NSArray()

    do {
        result = try self.managedObjectContext.executeFetchRequest(fetchRequest)
    } catch {
        let fetchError = error as NSError
        print(fetchError)
    }
    return result
}

我认为这个问题在于将newEntry作为一个NSManagedObject。

任何想法如何解决这个问题并摆脱nils?

提前致谢

修改 这是通过实施Wain建议

创建的实际工作代码
func updateRecord(entity: String, updateBasedOnKey: String, values: NSMutableArray){
    let entityDescription = NSEntityDescription.entityForName(
        entity, inManagedObjectContext: self.managedObjectContext)
    let results = getRecords(entity)

    for(elements) in values{
        //set to true if value was already found and updated
        var newEntry : NSManagedObject?
        //Determine whether to add new result or update existing
        if(results.count > 0){
            for result in results{
                let entry = result as! NSManagedObject
                if let keyValueToCompare = entry.valueForKey(updateBasedOnKey){
                    if (keyValueToCompare.isEqual(elements.valueForKey(updateBasedOnKey)) ){
                        //asign newEntry to result if found in entries
                        newEntry = entry
                    }
                }
            }
        }
        if newEntry == nil {
            newEntry = NSManagedObject(entity: entityDescription!, insertIntoManagedObjectContext: self.managedObjectContext)
        }
        for(key, value) in elements as! NSMutableDictionary{
            newEntry!.setValue(value, forKey: key as! String)
        }
    }
}

1 个答案:

答案 0 :(得分:1)

你是对的,问题是你每次都在创建和插入一个新对象。相反,您应该传递对象以更新或运行获取请求以找到它,然后更新它。

看起来你的目的是获取,新条目应该只是一个引用,而不是初始化。所以:

var newEntry : NSManagedObject?
相关问题