不可测试的grails(2.5.4)服务使用@PostConstruct和Spock单元测试

时间:2016-07-30 16:27:01

标签: unit-testing grails groovy grails-2.0 spock

我希望使用@PostConstuct初始化我的服务,方法是在Config.groovy中获取一些配置条目。

我还希望检查这些条目是否已正确配置,并抛出异常,以便我看到应用程序配置错误。

在为这项服务编写单元测试时,我在Spock中走到了尽头。

Spock显然调用@PostConstruct方法,但仅在共享服务实例上调用,然后在被测实际实例上执行您测试的任何实例方法。

这有副作用:

我的初始化代码失败,因为我无法添加setupSpec来初始化共享实例,或者它在测试中的方法失败,因为实际上没有在该实例上设置配置。

这是我的服务:

package issue

import org.codehaus.groovy.grails.commons.GrailsApplication

import javax.annotation.PostConstruct

class MyService {
    GrailsApplication grailsApplication
    String property

    @PostConstruct
    void init() {
        println "Initializing... ${this}"
        property = grailsApplication.config.myProperty

//Enabling this business sanity check make the service untestable under Spock, because to be able to run, we need to initialize the configuration
// of the shared instance - PostConstruct is only called on the shared instance for some reason.
// But the execution of the method under test will not have the initialized property, because the service being executed is not the shared instance
        if (property == "[:]") {
            throw new RuntimeException("This property cannot be empty")
        }
    }


    void doSomething() {
        println "Executing... ${this}"
        println(property.toLowerCase())
    }
}

这是我的第一次测试:

package issue

import grails.test.mixin.TestFor
import spock.lang.Specification

@TestFor(MyService)
class MyServiceSpec extends Specification {

    def setup() {
        grailsApplication.config.myProperty = 'myValue'
    }

    void "It fails to initialize the service"() {
        expect:
        false // this is never executed
    }
}

这是第二次测试:

package issue

import grails.test.mixin.TestFor
import spock.lang.Specification

@TestFor(MyService)
class MyServiceWithSharedInstanceInitializationSpec extends Specification {

    //Initializing the shared instance grailsApplication lets the @PostConstruct work, but will fail during method test
    //because the instance that was initialized is the shared instance
    def setupSpec() {
        grailsApplication.config.myProperty = 'myValue'
    }

    void "It fails to execute doSomething"() {
        when:
        service.doSomething()

        then:
        def e = thrown(NullPointerException)
        e.message == 'Cannot invoke method toLowerCase() on null object'
        service.property == null
    }
}

有没有办法干净利落地做到这一点?或者我是否必须放弃我的单元测试并进行(较慢的)集成测试,以此来解决这个奇怪的问题?

您可以在此处查看我的完整Grails应用程序:

https://github.com/LuisMuniz/grails-spock-issue-with-postconstruct

1 个答案:

答案 0 :(得分:3)

  

我的初始化代码失败,因为我无法添加setupSpec来初始化共享实例,或者它在测试中的方法失败,因为实际上没有在该实例上设置配置。

我的建议是简单地调用init方法,因为您正在测试方法的逻辑和功能,而不是@PostConstruct是否有效,这似乎是最有意义的。

相关问题