Rspec阻止调用方法

时间:2017-01-22 13:34:30

标签: ruby-on-rails ruby rspec mocking stub

我正在测试一种用于创建新订单的控制器方法(类似电子商务的应用程序)。如果系统中存在用户,则应将其重定向到new_user_session_path,否则重定向到new_order_path。就这么简单。

这是我的orders_controller.rb

def new
        if !User.where(phone: params[:phone]).blank? && !user_signed_in?

            redirect_to new_user_session_path()
            flash[:info] = "Already present"
        else
            @order = Order.new
            @menu = Menu.find(params[:menu_id])
            @menu_price = @menu.calculate_price(@menu, params)
        end
    end

在我的应用中,我需要调用calculate_price方法,因为它会根据参数计算总体价格。但在我的测试中,我只想确保重定向是正确的。

现在我收到错误(它们来自Menu.rb文件,因为调用了calculate_price):

Front::OrdersController#new redirects user to new order page if user is not present in the system
     Failure/Error: menu_price_change = menu_amount.split(",")[1].gsub(" ","").gsub("]",'')

     NoMethodError:
       undefined method `split' for nil:NilClass

这是我的spec文件:

require 'rails_helper'


describe Front::OrdersController, type: :controller do
    describe '#new' do
        # Set up dummy menu
        let (:menu) { Menu.create() }

        it "redirects user to sign up page if user is present in the system" do
            user = User.create(name: "Bob", password: "bobspassword", phone: "+7 (903) 227-8874")

            get :new, params: { phone: user.phone }
            expect(response).to redirect_to(new_user_session_path(phone: user.phone))
        end

        it "redirects user to new order page if user is not present in the system" do
            non_present_phone = "+7 (903) 227-8874"    
            get :new, params: { phone: non_present_phone, menu_id: menu.id}
            expect(response).to redirect_to(new_order_path)
        end

    end
end

当然我可以提供所有参数,但是它们数量非常多,而且我只想测试正确的重定向。据我所知,当你想要显式测试方法时,模拟和子函数在这种情况下很有用。但在我的情况下,我想 - 以某种方式 - 省略它们。我该如何确保这种行为?

1 个答案:

答案 0 :(得分:3)

因此,您只想测试重定向以及在calculate_price方法执行时发生的错误。你为什么不把那个方法存根?您的spec文件可能是这样的:

require 'rails_helper'


describe Front::OrdersController, type: :controller do
    describe '#new' do
        # Set up dummy menu
        let (:menu) { Menu.create() }

        # Check this out
        before do
          allow_any_instance_of(Menu).to receive(:calculate_price)
          # or if you need certain value
          allow_any_instance_of(Menu).to receive(:calculate_price).and_return(your_value)
        end

        it "redirects user to sign up page if user is present in the system" do
            user = User.create(name: "Bob", password: "bobspassword", phone: "+7 (903) 227-8874")

            get :new, params: { phone: user.phone }
            expect(response).to redirect_to(new_user_session_path(phone: user.phone))
        end

        it "redirects user to new order page if user is not present in the system" do
            non_present_phone = "+7 (903) 227-8874"    
            get :new, params: { phone: non_present_phone, menu_id: menu.id}
            expect(response).to redirect_to(new_order_path)
        end

    end
end