Question

我是Ruby和Rspec的新手。我正在编写我的第一个RSpec测试，我认为我的代码不是很好。但我不知道如何才能让它变得更好。

在这个文件中，我将检查我的地址类。 first_name和last_name是相同的，但我有两个大块。我怎样才能重构我的代码？什么是检查RegExp的好方法。

谢谢。

specify { Factory.build(:address).should be_valid }


  ### first_name ###

  it "should be invalid without an first_name" do
    Factory.build(:address, :first_name => nil).should_not be_valid
  end


  context "first_name" do

    it "should be invalid with more than 20 chars" do
      Factory.build(:address, :first_name => "#{'b'*21}").should_not be_valid
    end

    it "should be invalid with less than 3 chars" do
      Factory.build(:address, :first_name => "ll").should_not be_valid
    end

    it "should be valid with an valid first_name" do      
       valid_names.each do |name|
        Factory.build(:address, :first_name => name).should be_valid
       end
    end

    it "should be invalid with an invalid first_name" do
      invalid_names.each do |name|
        Factory.build(:address, :first_name => name).should_not be_valid
      end
    end    
  end


  ### last_name ###

  it "should be invalid without an last_name" do
    Factory.build(:address, :last_name => nil).should_not be_valid
  end

  context "last_name" do
    it "should be invalid with more than 20 chars" do
      Factory.build(:address, :last_name => "#{'b'*21}").should_not be_valid
    end

    it "should be invalid with less than 3 chars" do
      Factory.build(:address, :last_name => "ll").should_not be_valid
    end

    it "should be valid with an valid last_name" do      
       valid_names.each do |name|
        Factory.build(:address, :last_name => name).should be_valid
       end
    end

    it "should be invalid with an invalid last_name" do
      invalid_names.each do |name|
        Factory.build(:address, :last_name => name).should_not be_valid
      end
    end    
  end
 def valid_names    
    ["Kai","Ülück's","Schmeißtzs","Rald","Dr. Franzen","rolfes","Lars Michael","Öcück","Mark-Anthony"] 
  end

  def invalid_names    
    ["-#+*32","         ","a& &lkdf","_-_.l##df"," aaadsa","M€lzer"]
  end

Answer 1

所以这就是我有时做这种事情的方式：

describe Address do
  describe "validations" do
    before do
      @address = Factory(:address)
    end
    describe "#first_name" do
      #prove that your factory is correct
      it "should be valid" do
        @address.should be_valid
      end
      it "should be less than 20 chars" do
        @address.name = "0" * 20
        @address.should_not be_valid
      end
      it "should be more than 3 chars" do
        @address.name = "000"
        @address.should_not be_valid
      end
    end
  end
end

Answer 2

请记住，您的测试不需要真正干燥。不要为此牺牲可读性。

将您的规范视为示例：哪些示例应该有效，哪些不应该？这也是测试正则表达式的线索：提供一些通过的例子和一些不通过的例子。

对于验证，我制作了一些自定义匹配器，可以找到here。例如：

describe Address do
  it { should deny(:last_name).to_be(nil, "", "1", "br", "a& &lkdf","_-_.l##df", "lzer") }
  it { should allow(:last_name).to_be("Kai","Ülück's","Schmeißtzs","Rald","Dr. Franzen","rolfes","Lars Michael","Öcück","Mark-Anthony") }
end

用Rspec干燥问题如何解决它

2 个答案: