VBA代码效率 - excel Ranges

时间:2017-09-01 10:57:35

标签: excel vba excel-vba

我有一个我在下面运行的代码,工作正常。

问题:是否有更有效的方法来编写此代码? (短)

Private Sub Worksheet_BeforeDoubleClick(ByVal Target As Range, Cancel As Boolean)
    If Not Intersect(Target, Range("D24")) Is Nothing Then
              Sheet2.Range("D24") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")
    End If
     If Not Intersect(Target, Range("D20")) Is Nothing Then
              Sheet2.Range("D20") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")
    End If
    If Not Intersect(Target, Range("D25")) Is Nothing Then
              Sheet2.Range("D25") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")
    End If
     If Not Intersect(Target, Range("D27")) Is Nothing Then
              Sheet2.Range("D27") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")
    End If
     If Not Intersect(Target, Range("D28")) Is Nothing Then
              Sheet2.Range("D28") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")
    End If
    If Not Intersect(Target, Range("D30")) Is Nothing Then
              Sheet2.Range("D30") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")
    End If
    If Not Intersect(Target, Range("D31")) Is Nothing Then
              Sheet2.Range("D31") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")
    End If
    If Not Intersect(Target, Range("D32")) Is Nothing Then
              Sheet2.Range("D32") = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")

End Sub

2 个答案:

答案 0 :(得分:1)

假设文本不在同一张纸上,这个?

Private Sub Worksheet_BeforeDoubleClick(ByVal Target As Range, Cancel As Boolean)

If Intersect(Target, Range("D20,D24,D25,D27,D28,D30,D31,D32")) Is Nothing Then Exit Sub
'Cancel=True
Sheet2.Range(Target.Address).Value = "Prepared By" & "  " & Environ("Username") & "  " & Format(Now(), "yyyy-MM-dd hh:mm:ss")

End Sub

答案 1 :(得分:1)

另一种选择,不使用Intersect:

Option Explicit

Private Sub Worksheet_BeforeDoubleClick(ByVal Target As Range, Cancel As Boolean)

    With Target
        If .Column = 4 Or .Column = 5 Then
            Select Case .Row
                Case 20, 24, 25, 27 To 28, 30 To 32

                    Application.EnableEvents = False

                    .Value2 = "Prepared By" & "  " & Environ("Username")
                    .Value2 = .Value2 & "  " & Format(Now, "yyyy-MM-dd hh:mm:ss")

                    Application.EnableEvents = True

            End Select
        End If
    End With
End Sub