修改按钮数组中的按钮

时间:2017-09-20 17:01:01

标签: android android-button

我正在尝试编写一个程序,这样每当按下名为“front”的按钮时,除了等于GreenButton的按钮外,所有其他按钮都将变为灰色。我正在努力访问for循环中的按钮,并继续获得空指针异常。

完整的logcat如下所示,显示当我尝试在循环中访问数组时NPE正在发生

09-20 11:50:54.727 5302-5302/com.example.kshah.movingbutton E/AndroidRuntime: FATAL EXCEPTION: main
  Process: com.example.kshah.movingbutton, PID: 5302
  java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.Button.setBackgroundColor(int)' on a null object reference
      at com.example.kshah.movingbutton.MainActivity$1.onTouch(MainActivity.java:108)
      at android.view.View.dispatchTouchEvent(View.java:9296)
      at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
      at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2197)
      at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
      at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2197)
      at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
      at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2197)
      at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
      at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2197)
      at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
      at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2197)
      at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
      at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2197)
      at com.android.internal.policy.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:2403)
      at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1737)
      at android.app.Activity.dispatchTouchEvent(Activity.java:2771)
      at android.support.v7.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69)
      at com.android.internal.policy.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:2364)
      at android.view.View.dispatchPointerEvent(View.java:9520)
      at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:4230)
      at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:4096)
      at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3642)
      at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3695)
      at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3661)
      at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:3787)
      at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3669)
      at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:3844)
      at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3642)
      at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3695)
      at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3661)
      at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3669)
      at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3642)
      at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:5922)
      at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:5896)
      at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:5857)
      at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:6025)
      at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:185)
      at android.os.MessageQueue.nativePollOnce(Native Method)
      at android.os.MessageQueue.next(MessageQueue.java:323)
      at android.os.Looper.loop(Looper.java:135)
      at android.app.ActivityThread.main(ActivityThread.java:5417)
      at java.lang.reflect.Method.invoke(Native Method)
      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

CODE:

public class MainActivity extends AppCompatActivity {

  private Button front;
  private Button a;
  private Button b1;
  private Button b2;
  private Button b3;
  private Button b4;

  Button[] buttons = {front,a,b1,b2,b3,b4};

  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    front = (Button) findViewById(R.id.front);
    a = (Button) findViewById(R.id.a);
    b1 = (Button) findViewById(R.id.b1);
    b2 = (Button) findViewById(R.id.b2);
    b3 = (Button) findViewById(R.id.b3);
    b4 = (Button) findViewById(R.id.b4);

    front.setOnTouchListener(new View.OnTouchListener() {
        @Override
        public boolean onTouch(View view, MotionEvent event) {
                Button GreenButton = b3;
            for(int i = 0; i <= buttons.length; i++) {
                if (buttons[i] == b3) {
                    buttons[i].setBackgroundColor(Color.GREEN);
                }
                else
                    buttons[i].setBackgroundColor(Color.GRAY);
            }
            return false;
        }
    });
  }
}

3 个答案:

答案 0 :(得分:2)

您无法将引用存储在初始化程序数组中,如此

Button[] buttons = {front,a,b1,b2,b3,b4};

但为什么呢?我们去Array Initializers

  

要构造的数组的长度等于   变量初始化器立即被数组的大括号括起来   初始化。为该长度的新数组分配空间。如果   没有足够的空间来分配数组,评估了   数组初始值设定项通过抛出OutOfMemoryError突然完成。   否则,a one-dimensional array is created of the specified length,   and each component of the array is initialized to its default value

所以这里的引用只会被值null替换,因此它们无法再跟踪实际参考值的变化轨迹

所以解决方案是声明arrayArrayList需要的长度并添加对它的引用。

//                  {null,null,null,....}
//Button[] buttons = {front,a,b1,b2,b3,b4};
  Button[] buttons = new Button[6];

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    buttons[0] = (Button) findViewById(R.id.front);
    buttons[1] = (Button) findViewById(R.id.a);
    buttons[2] = (Button) findViewById(R.id.b1);
    buttons[3] = (Button) findViewById(R.id.b2);
    buttons[4] = (Button) findViewById(R.id.b3);
    buttons[5] = (Button) findViewById(R.id.b4);

    buttons[0].setOnTouchListener(new View.OnTouchListener() {
        @Override
        public boolean onTouch(View view, MotionEvent event) {
                Button GreenButton = b3;
            // note < instead of <=
            for(int i = 0; i < buttons.length; i++) {
                if (buttons[i] == buttons[4]) {
                    buttons[i].setBackgroundColor(Color.GREEN);
                }
                else
                    buttons[i].setBackgroundColor(Color.GRAY);
            }
            return false;
        }
    });

答案 1 :(得分:1)

您可以尝试使用新的Button [size],如下所示:

// allocates memory for 6 button.
Button[] buttons = new Button[6]; 

然后,添加按钮:

front = (Button) findViewById(R.id.front);
a = (Button) findViewById(R.id.a);
b1 = (Button) findViewById(R.id.b1);
b2 = (Button) findViewById(R.id.b2);
b3 = (Button) findViewById(R.id.b3);
b4 = (Button) findViewById(R.id.b4);

buttons[0] = front;
buttons[1] = a;
buttons[2] = b1;
buttons[3] = b2;
buttons[4] = b3;
buttons[5] = b4;

<强>解释

使用以下命令创建数组时

private Button front;
private Button a;
private Button b1;
private Button b2;
private Button b3;
private Button b4;

Button[] buttons = {front,a,b1,b2,b3,b4};

您正在创建一个包含空对象元素的数组,类似于

Button[] buttons = {null,null,null,null,null,null};

然后当您将Button分配给其中一个数组成员时使用:

front = (Button) findViewById(R.id.front);

您要将对象分配给front而不是buttons[0]

您可以尝试以下代码来理解上述解释的含义:

public class MainActivity extends AppCompatActivity {
  public static final String TAG = MainActivity.class.getSimpleName();

  private Button front;
  private Button a;
  private Button b1;
  private Button b2;
  private Button b3;
  private Button b4;

  Button[] buttons = {front,a,b1,b2,b3,b4};

  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    // Check address:
    Log.d(TAG, "Before initializing..");
    for(int i = 0; i < buttons.length; i++) {
      Log.d(TAG, "i " + buttons[i]);
    }
    front = (Button) findViewById(R.id.front);
    a = (Button) findViewById(R.id.a);
    b1 = (Button) findViewById(R.id.b1);
    b2 = (Button) findViewById(R.id.b2);
    b3 = (Button) findViewById(R.id.b3);
    b4 = (Button) findViewById(R.id.b4);
    Log.d(TAG, "After initializing..");
    for(int i = 0; i < buttons.length; i++) {
      Log.d(TAG, "i " + buttons[i]);
    }

    Log.d(TAG, "After assigning..");
    Log.d(TAG, "front " + front);
    Log.d(TAG, "a " + a);
    Log.d(TAG, "b1 " + b1);
    Log.d(TAG, "b2 " + b2);
    Log.d(TAG, "b3 " + b3);
    Log.d(TAG, "b4 " + b4);

  }
}

答案 2 :(得分:0)

public func pickerView(_ pickerView: UIPickerView, didSelectRow row: Int, inComponent component: Int) { for textField in textFields { if textField.isEditing { textField.text = country[row] } } self.view.endEditing(false) } 绝不是一个有效的“for”循环,原因很简单。它总是会给你NullPointerException,因为在循环的最后一个循环中,当i == buttons.length();你试图对按钮[buttons.length()]执行一个操作,它根本就不存在。

尝试for(int i = 0; i <= buttons.length; i++){do something with buttons[i]}