继承的模板化单例类c ++中的未定义构造函数

时间:2018-01-24 11:40:15

标签: c++ inheritance singleton

我今天遇到了一个问题,使用了我之前做过的工具:一个Singleton模板化的类。

template <class C>
class Singleton {
    /*! \class Singleton
    * \brief Singleton Template
    */
public:
    /*!
    * \brief Public access interface
    * \return Singleton instance
    */
    static C *getInstance (){
        // Create new instance if not initialised
        if (_singleton == NULL){
            _singleton = new C;
        }
        return (static_cast<C*> (_singleton));
    }

    /*!
    * \brief Public access destructor
    */
    static void kill(){
        // Clean Singleton object and free memory
        if (_singleton != NULL){
            delete _singleton;
            _singleton = NULL;
        }
    }
protected:
    /*!
     * \brief Empty constructor
     */
    Singleton() = default;
    /*!
     * \brief Destructor
     */
    virtual ~Singleton() = default;

private:
    static C *_singleton; /*!< Unique instance */
};

template <class C>
C *Singleton<C>::_singleton = NULL;

当我尝试在(非常基本的)继承类上调用TextureManager :: getInstance()时出现问题,如下所示:

class TextureManager : public Singleton<TextureManager> {
    friend class Singleton<TextureManager>;
    /*! \class TextureManager
    * \brief Textures Container
    */
public:
protected:
    /*!
     * \brief Empty constructor
     */
    TextureManager();
    /*!
     * \brief Destructor
     */
    ~TextureManager() override;
private:
};

在编译期间,链接器向我显示了一个我理解的错误,但我真的不明白原因:

build/main.o: In function `Singleton<TextureManager>::getInstance()':
main.cpp (.text._ZN9SingletonI14TextureManagerE11getInstanceEv[_ZN9SingletonI14TextureManagerE11getInstanceEv]+0x24): undefined reference to `TextureManager::TextureManager()'

似乎无法找到TextureManager.cpp

中构造函数的定义
TextureManager::TextureManager() = default;
TextureManager::~TextureManager() = default;

这个代码适用于我使用premake编译的旧项目,所以我的猜测是我当前的makefile是垃圾,但我找不到原因......

INCLUDE = -I/usr/X11R6/include/
LIBDIR  = -L/usr/X11R6/lib

SRCDIR := sources
BUILDDIR := build
TARGET := bin/game

SRCEXT := cpp
SOURCES := $(shell find $(SRCDIR) -type f -name *.$(SRCEXT))
OBJECTS := $(patsubst $(SRCDIR)/%,$(BUILDDIR)/%,$(SOURCES:.$(SRCEXT)=.o))

FLAGS = -std=c++11 -Wall
CC = g++
CFLAGS = $(FLAGS) $(INCLUDE)
LIBS =  -lglut -lGL -lGLU -lGLEW -lm

$(TARGET): $(OBJECTS)
    @echo "Linking..."
    @echo "$(CC) $(CFLAGS) $^ -o $@ $(LIBDIR) $< $(LIBS)"; $(CC) $(CFLAGS) -o $@ $(LIBDIR) $< $(LIBS)

$(BUILDDIR)/%.o: $(SRCDIR)/%.$(SRCEXT)
    @mkdir -p $(@D)
    @echo "$(CC) $(CFLAGS) -o $@ $(LIBDIR) $< $(LIBS)"; $(CC) $(CFLAGS) -c -o $@ $(LIBDIR) $< $(LIBS)

clean:
    @echo "Cleaning..."
    @echo "$(RM) -r $(BUILDDIR) $(TARGET)"; $(RM) -r $(BUILDDIR) $(TARGET)

.PHONY: clean

现在已经坚持了好几个小时 我所有的希望都在你身上:p

编辑:完整输出

g++ -std=c++11 -Wall -I/usr/X11R6/include/ -o build/main.o -L/usr/X11R6/lib sources/main.cpp -lglut -lGL -lGLU -lGLEW -lm
g++ -std=c++11 -Wall -I/usr/X11R6/include/ -o build/Tools/ThreadManager.o -L/usr/X11R6/lib sources/Tools/ThreadManager.cpp -lglut -lGL -lGLU -lGLEW -lm
g++ -std=c++11 -Wall -I/usr/X11R6/include/ -o build/Graphics/GraphicalEngine.o -L/usr/X11R6/lib sources/Graphics/GraphicalEngine.cpp -lglut -lGL -lGLU -lGLEW -lm
g++ -std=c++11 -Wall -I/usr/X11R6/include/ -o build/Graphics/TextureManager.o -L/usr/X11R6/lib sources/Graphics/TextureManager.cpp -lglut -lGL -lGLU -lGLEW -lm
Linking...
g++ -std=c++11 -Wall -I/usr/X11R6/include/ build/main.o build/Tools/ThreadManager.o build/Graphics/GraphicalEngine.o build/Graphics/TextureManager.o -o bin/game -L/usr/X11R6/lib build/main.o -lglut -lGL -lGLU -lGLEW -lm
build/main.o: In function `Singleton<TextureManager>::getInstance()':
main.cpp:(.text._ZN9SingletonI14TextureManagerE11getInstanceEv[_ZN9SingletonI14TextureManagerE11getInstanceEv]+0x24): undefined reference to `TextureManager::TextureManager()'
collect2: error: ld returned 1 exit status
makefile:18: recipe for target 'bin/game' failed
make: *** [bin/game] Error 1

1 个答案:

答案 0 :(得分:1)

问题是您只使用$(TARGET)规则中的第一个依赖项:

$(CC) $(CFLAGS) -o $@ $(LIBDIR) $< $(LIBS)
#                               ^^

我的评论实际上是错误的,因为@echo和实际命令之间有不同的命令:

@echo "$(CC) $(CFLAGS) $^ -o $@ $(LIBDIR) $< $(LIBS)"
#                      ^^                 ^^

我在这里添加echo行没有意义,我会按照以下步骤操作:

$(TARGET): $(OBJECTS)
    @echo "Linking..."
    $(CC) $(CFLAGS) $^ -o $@ $(LIBDIR) $(LIBS)
    #               ^^

如果你这样做了,我会更快地看到你的错误。