可调用项的执行顺序不一致

时间:2018-07-13 09:51:04

标签: java multithreading concurrency callable

我有这段代码在其中执行一组可调用对象,在触发下一组之前,我需要一组来完成所有工作。这段代码似乎工作正常,但有时下一组代码会在时间之前开始运行。怎么了?

private void executeSubGraph(QuestExecutionContext ctx, Set<Activity> subGraph, int progressAfterRan) {
    ExecutorService pool = Executors.newFixedThreadPool(16);
    subGraph.forEach(a -> {
        ActivityRunner<? extends Activity> runner = activityRunnerFactory.getRunner(ctx, a);
        if (runner != null) {
            Callable<List<PortValuePart>> runnerCallable = () -> {
                try {
                    LOG.info("Running {} in {}", a, a.getClass() );
                    List<PortValuePart> result = runner.call();
                    LOG.info("Result of {} in {} is {}", a, a.getClass(), result);
                    if (result != null) {
                        result.forEach(r -> resultProcessor.processResult(new PortValuePartEnvelope(r)));
                    }
                    return result;
                } catch (Exception e) {
                    LOG.warn("Exception for {} in {}", a, runner.getClass(), e);
                    resultProcessor.processResult(Progress.failed(ctx.getId(), e));
                    throw new RuntimeException(e);
                }
            };
            Future<List<PortValuePart>> p = pool.submit(runnerCallable);
        } else {
            LOG.warn("No runner found for activity {}", a);
            resultProcessor.processResult(Progress.failed(ctx.getId(), new RuntimeException("No runner found for activity " + a)));
            throw new RuntimeException("No runner found for activity " + a);
        }
    });

    pool.shutdown();

    try {
        pool.awaitTermination(WAIT_TIME_MILLIS, TimeUnit.MILLISECONDS);
        resultProcessor.processResult(Progress.running(ctx.getId(), progressAfterRan));
    } catch (InterruptedException e) {
        throw new PlatformException("Execution interrupted.");
    }
}

1 个答案:

答案 0 :(得分:0)

请注意,ExecutorService.awaitTermination不会在超时时抛出异常。它只返回false。如果要确保下次调用不会与这些调用并发运行,则可能应该使用返回值,并且如果调用时间太长,则可能抛出异常(并杀死任务)。