内存释放问题 - UIImages的NSArray

时间:2011-03-14 05:46:44

标签: iphone memory memory-management uiviewcontroller uiimage

我遇到了记忆问题。我可能不明白如何从导航控制器中弹出当前的UIViewcontroller。但是我认为它会释放它的内存,至少在它运行不足的时候。就像调用dealloc方法一样。我有一个继承自UIViewController的类。我基本上做了一个png动画序列。我不能使用animationImages,因为我需要一些交叉淡入淡出。无论如何,当我观看活动监视器并打开页面时(观察内存上升30MB)然后我弹出它。内存减少了几MB但不是全额。所以这一直在发生,直到应用程序崩溃。泄漏检测器不显示任何泄漏的物体。我想我正在照顾它。我可以粘贴我的代码,如果这会有所帮助。有什么我不了解的NavigationController和发布UIViewControllers?

以下是代码:

-(void)addImage:(NSString*)imageName{
    if (!images){
        images = [[NSMutableArray alloc] init];
    }

//    UIImage*image = [[UIImage alloc] initWithContentsOfFile:[[NSBundle mainBundle]  pathForResource:[imageName stringByReplacingOccurrencesOfString:@".png" withString:@""] ofType:@"png"]];
    [images addObject:imageName];
  //  [image release];
}

-(UIImage*)getImage:(NSString*)imageName{
    return [UIImage imageNamed:imageName];
}

// left pad the image number with 0
-(NSString*)formatImageName:(int)num andName:(NSString*)imgName{
    NSString* imgNum = [NSString stringWithFormat:@"%i",num];
    if (num < 10){
        imgNum = [NSString stringWithFormat:@"0%i",num];
    }
    return [NSString stringWithFormat:imgName,imgNum];
}
// Returns a UIImageView that contains the next image to display
- (UIImageView *)nextImageView
{
    if(runOnce && hasRunOnce && pictureIndex == 0){
        return nil;
    }
    // get the image at the next index
    UIImage *image = [self getImage:[images objectAtIndex:pictureIndex]];
    ++pictureIndex; // increment the index




    // create an image view for the image
    UIImageView *imageView = [[UIImageView alloc] initWithImage:image];
    //[image release];

    // resize the image to fill the screen without distorting
    imageView.frame = rotator.frame;

    imageView.autoresizesSubviews = NO;
    [imageView setContentMode:UIViewContentModeCenter];


    // Makes the image move proportionally in any direction if the
    // bounds of the superview change when the iPhone is rotated.
    imageView.autoresizingMask = (UIViewAutoresizingFlexibleLeftMargin |
                                  UIViewAutoresizingFlexibleRightMargin |                          
                                  UIViewAutoresizingFlexibleTopMargin |                            
                                  UIViewAutoresizingFlexibleBottomMargin);

    if(pictureIndex > images.count -1){
        pictureIndex = 0;
    }

    hasRunOnce = YES;
    return imageView;
}

- (void)timerFired:(NSTimer *)_timer{
    nextImageView = [self nextImageView];
    if(nextImageView){
        [self.view addSubview:nextImageView];
        nextImageView.alpha = 0.0;

        //NSLog(@"timerFired - image no: %i", pictureIndex);

        // begin animation block
        [UIView beginAnimations:nil context:nextImageView];
        [UIView setAnimationDuration:animationDuration]; // set the animation length
        [UIView setAnimationDelegate:self]; // set the animation delegate

        // call the given method when the animation ends
        [UIView setAnimationDidStopSelector:@selector(transitionFinished:finished:context:)];

        // make the next image appear with the chosen effect
        [nextImageView setAlpha:1.0]; // fade in the next image
        [currentImageView setAlpha:0.0]; // fade out the old image

        [UIView commitAnimations];
    } else {
        [timer invalidate];
        timer = nil;
    }

}

// called when the image transition animation finishes
- (void)transitionFinished:(NSString *)animationId finished:(BOOL)finished context:(void *)context
{
    [currentImageView removeFromSuperview]; // remove the old image
    currentImageView.image = nil;
    [currentImageView release]; // release the memory for the old image
    currentImageView = context; // assign the new image
}

-(void)startRotator{
    pictureIndex = 0; // reset the index

    currentImageView = [self nextImageView]; // load the first image
    [self.view addSubview:currentImageView]; // add the image to the view

    timer = [NSTimer scheduledTimerWithTimeInterval:scheduledInterval 
                                             target:self
                                           selector:@selector(timerFired:) 
                                           userInfo:nil 
                                            repeats:YES];
}

-(void)stopRotator{
    NSLog(@"ImageRotator - StopRotator Called");
    [timer invalidate];
    timer = nil; // set timer to nil
    [currentImageView removeFromSuperview]; // remove the current image
    currentImageView.image = nil;

    [currentImageView release];
    currentImageView = nil;
    if(nextImageView){
        [nextImageView removeFromSuperview]; // remove the current image
        nextImageView.image = nil;
        //[nextImageView release];
        nextImageView = nil;
    }
}

// called after this controller's view was dismissed, covered or otherwise hidden
- (void)viewWillDisappear:(BOOL)animated
{   
    [self stopRotator];
    [images release];
    images = nil;
    [super viewWillDisappear:animated];
}

3 个答案:

答案 0 :(得分:1)

首先,内存突然增加,因为你将所有图像存储在数组中,因为我建议你将它们存储在文档目录和数组中所有那些(stings数组)的地址中。 减少内存使用的一个想法是使用

myImageView.image = nil;

如果您使用任何imageView显示图像,则在您不显示任何图像时使用上面的行。 有一点需要注意的是,当应用程序内存不足时,它会调用

- (void)didReceiveMemoryWarning { 
}

- (void)dealloc {
}

我建议你阅读内存管理

此外,您可以使用Instruments来检查内存泄漏

答案 1 :(得分:0)

我认为你应该改变的第一件事是下面的代码

- (void)timerFired:(NSTimer *)_timer
{
// all your code 
 .......
 .......
//add these two lines at bottom

[nextImageView release];
 //I think the leak is because you are adding imageViews and not releasing it .... when ever you add any subview to any view its retain count is incleased.
currentImageView.image = nil;
//also you are not using current view any more because you are setting its alfa to 0 so you can set its image to nil.

}

答案 2 :(得分:0)

内存问题最终成为ImageNamed方法。一旦我用其他方法用以下方法覆盖它,一切似乎都运行良好。

@implementation UIImage(imageNamed_Hack)
+ (UIImage *)imageNamed:(NSString *)name {
    return [UIImage imageWithContentsOfFile:[[NSBundle mainBundle] pathForResource:name ofType:nil]];
}
@end