我不明白为什么在此代码中两次执行displayAllTodoItems()

时间:2018-12-15 14:20:19

标签: javascript node.js

给出的代码是在NodeJS中创建的控制台Todo应用程序,它可以存储新的Todo项目,显示它们并能够删除任何一项。我面临的问题是,当我向应用程序中添加新的Todo项,然后不停止程序时,我尝试显示所有使用displayAllTodoItems()存储的Todo项,结果显示两次。但是,如果我在停止应用程序一次后执行displayAllTodoItems(),则不会发生这种情况。谁能告诉我为什么会这样吗?

const fs = require('fs');
const readline = require('readline');

const rl = readline.createInterface({
    input: process.stdin,
    output: process.stdout
});

let outputData;
console.log(`Welcome to Todo app!
-----------------------------------
Press 1 to add a new Todo item.
Press 2 to display all Todo items.
Press 3 to delete a Todo item.
Press 4 to exit.`);
takeInput();

function takeInput(){
    rl.on("line", (answer) => {
        checkSwitch(answer);
    });
}

function checkSwitch(answer) {
    if(answer == "1"){
        rl.question("Give the name and description of the Todo item (separated by a comma):", (ans) => {
            let [name, description] = ans.split(",");
            addNewTodoItem(name, description);
        });   
    }
    else if(answer == "2"){
            displayAllTodoItems();
    }
    else if(answer == "3"){
        rl.question("Give the number of the Todo item to be deleted:", (ans) => {
            let number = ans;
            deleteATodoItem(number);
        });   
    }
    else if(answer == "4"){
        console.log("Program exited!")
        process.exit();
    }
    else {
        console.log("Invalid selection!")
    }
    takeInput();

}

const addNewTodoItem = (name, description) => {
    fs.readFile("todofile.txt", "UTF-8", (err) => {
        if(err){
            fs.writeFile("todofile.txt", `${name}:${description}\n`, (err) => {
                if(err){
                    console.log("The data couldn't be saved.");
                }
                else{
                    console.log("The Todo item has been saved.");
                }
            });
        }
        else {
            fs.appendFile("todofile.txt", `${name}:${description}\n`, (err) => {
                if(err){
                    console.log("The data couldn't be saved.");
                }
                else{
                    console.log("The Todo item has been saved.");
                }
            });
        }
    });   
}

const displayAllTodoItems = () => {
    let text = fs.readFileSync("todofile.txt").toString('utf-8').split("\n");
    text = text.filter(text=>text!="");
    text.forEach((element, i)=> {
        console.log(`${i+1}. ${element}`);
    })
}
const deleteATodoItem = () => console.log("Delete");

我也已经发布了这个问题的答案。

1 个答案:

答案 0 :(得分:1)

似乎takeInput()中的checkSwitch()函数调用是问题的原因。该问题已解决。一旦在程序的开头执行了rl.on("line", callback)函数,takeInput()就会侦听新行条目。在takeInput()函数中再次调用checkSwitch()时,rl.on("line", callback)执行了两次,从而产生了问题。这是该应用程序的完整和更正版本:

const fs = require('fs');
const readline = require('readline');

const rl = readline.createInterface({
    input: process.stdin,
    output: process.stdout
});

let outputData;
console.log(`Welcome to Todo app!
-----------------------------------
Press 1 to add a new Todo item.
Press 2 to display all Todo items.
Press 3 to delete a Todo item.
Press 4 to exit.`);

takeInput();

function takeInput() {
    rl.on("line", (answer) => {
        checkSwitch(answer);
    });
}

function checkSwitch(answer) {
    if (answer == "1") {
        rl.question("Give the name and description of the Todo item (separated by a comma):", (ans) => {
            let [name, description] = ans.split(",");
            addNewTodoItem(name, description);
        });
    }
    else if (answer == "2") {
        displayAllTodoItems();
    }
    else if (answer == "3") {
        rl.question("Give the number of the Todo item to be deleted:", (ans) => {
            deleteATodoItem(ans);

        });
    }
    else if (answer == "4") {
        console.log("Program exited!")
        process.exit();
    }
    else {
        console.log("Invalid selection!");
    }
}

const addNewTodoItem = (name, description) => {
    fs.readFile("todofile.txt", "UTF-8", (err) => {
        if (err) {
            fs.writeFileSync("todofile.txt", `${name}:${description}\n`);
            console.log("The Todo item has been saved.");
        }
        else {
            fs.appendFile("todofile.txt", `${name}:${description}\n`, (err) => {
                if (err) {
                    console.log("The data couldn't be saved.");
                }
                else {
                    console.log("The Todo item has been saved.");
                }
            });
        }
    });
}

const displayAllTodoItems = () => {
    let text = fs.readFileSync("todofile.txt").toString('utf-8').split("\n");
    text = text.filter(text => text != "");
    text.forEach((element, i) => {
        console.log(`${i + 1}. ${element}`);
    });
}

const deleteATodoItem = (number) => {
    let text = fs.readFileSync("todofile.txt").toString('utf-8').split("\n");
    text = text.filter(text => text != "");
    text.splice(number - 1, 1);
    fs.writeFileSync("todofile.txt", text.join("\n"));
    console.log("Item deleted.");
}