StreamReader上的EnableRewind和LeaveOpen不会停止处理请求

时间:2019-03-12 09:12:51

标签: .net-core

我正在使用ApplicationInsights,我想将请求以及响应之后添加到日志记录属性中。

为此,我正在实现自己的ITelemetryInitializer。看起来就像这样。

    public class MyInitializer : ITelemetryInitializer
    {
        private readonly IHttpContextAccessor _httpContextAccessor;

        public MyInitializer(IHttpContextAccessor httpContextAccessor)
        {
            _httpContextAccessor = httpContextAccessor;
        }

        public void Initialize(ITelemetry telemetry)
        {
            var requestTelemetry = telemetry as RequestTelemetry;

            if (requestTelemetry == null || _httpContextAccessor?.HttpContext?.Request == null 
                || requestTelemetry.Properties.ContainsKey("RequestBody"))
            {
                return;
            }

            var request = _httpContextAccessor?.HttpContext?.Request;
            request?.EnableRewind();

            if (request.Method.Equals(HttpMethod.Post.ToString(), StringComparison.InvariantCultureIgnoreCase)
                || request.Method.Equals(HttpMethod.Put.ToString(), StringComparison.InvariantCultureIgnoreCase))
            {
                using (var reader = new StreamReader(request.Body, Encoding.UTF8, true, 1024, true))
                {
                    var requestBody = reader.ReadToEnd();
                    requestTelemetry.Properties.Add("RequestBody", requestBody);
                }
            }
        }
    }

在启动时,我已经添加了这个

services.AddHttpContextAccessor();
services.AddSingleton<ITelemetryInitializer, MyInitializer>();
services.AddApplicationInsightsTelemetry();

我得到的错误是:

ObjectDisposedException: Cannot access a disposed object.
Object name: FileBufferingReadStream.
Microsoft.AspNetCore.WebUtilities.FileBufferingReadStream.ThrowIfDisposed()

我已经使用.EnableRewind并指示StreamReader将文件保持打开状态。尽管如此,当我的请求实际到达我的控制器时,甚至再次到达初始化程序第二次(设置响应信息)时,我的请求仍为null。

欢迎提出任何建议。


此外,我尝试添加一块中间件以确保.EnableRewind可以用于所有功能,但这无济于事。我希望不必添加任何其他中间件,因为我希望没有其他依赖项。

app.Use(async (context, next) =>
{
    context.Request.EnableRewind();
    await next();
});

谢谢。

1 个答案:

答案 0 :(得分:0)

与往常一样,解决方案最终只是一行代码。我要感谢Gunnar Peipman先生的博客文章Reading request body in ASP.NET Core

该行: request.Body.Seek(0, SeekOrigin.Begin);

代码

public class MyInitializer : ITelemetryInitializer
{
    private readonly IHttpContextAccessor _httpContextAccessor;

    public MyInitializer(IHttpContextAccessor httpContextAccessor)
    {
        _httpContextAccessor = httpContextAccessor;
    }

    public void Initialize(ITelemetry telemetry)
    {
        var requestTelemetry = telemetry as RequestTelemetry;

        if (requestTelemetry == null || _httpContextAccessor?.HttpContext?.Request == null
                                     || requestTelemetry.Properties.ContainsKey("RequestBody"))
        {
            return;
        }

        var request = _httpContextAccessor?.HttpContext?.Request;
        request?.EnableRewind();

        if (request.Method.Equals(HttpMethod.Post.ToString(), StringComparison.InvariantCultureIgnoreCase)
            || request.Method.Equals(HttpMethod.Put.ToString(), StringComparison.InvariantCultureIgnoreCase))
        {
            using (var reader = new StreamReader(request.Body, Encoding.UTF8, true, 1024, true))
            {
                var requestBody = reader.ReadToEnd();
                request.Body.Seek(0, SeekOrigin.Begin);

                requestTelemetry.Properties.Add("RequestBody", requestBody);
            }
        }
    }
}
相关问题