程序可以运行,但是不能产生正确的输出?

时间:2019-03-17 10:17:15

标签: python python-2.7 primes

我制作了一个程序,该程序可以找到n个数字以下的素数。
这是代码:-

import time
n = 10000
start = time.time()

primes = [2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47, 53, 59, 
61, 67, 71, 73, 79, 83, 89, 97, 101, 103, 107, 109, 113, 127, 131, 137, 139, 
149, 151, 157, 163, 167, 173, 179, 181, 191, 193, 197, 199, 211, 223, 227, 
229, 233, 239, 241, 251, 257, 263, 269, 271, 277, 281, 283, 293, 307, 311, 
313, 317, 331, 337, 347, 349, 353, 359, 367, 373, 379, 383, 389, 397, 401, 
409, 419, 421, 431, 433, 439, 443, 449, 457, 461, 463, 467, 479, 487, 491, 
499, 503, 509, 521, 523, 541, 547, 557, 563, 569, 571, 577, 587, 593, 599, 
601, 607, 613, 617, 619, 631, 641, 643, 647, 653, 659, 661, 673, 677, 683, 
691, 701, 709, 719, 727, 733, 739, 743, 751, 757, 761, 769, 773, 787, 797, 
809, 811, 821, 823, 827, 829, 839, 853, 857, 859, 863, 877, 881, 883, 887, 
907, 911, 919, 929, 937, 941, 947, 953, 967, 971, 977, 983, 991, 997]
if n > 1000000:
    for j in range(1,n+1):
        for i in range(0,len(primes)):
            if j % primes[i] == 0:
                break
        else:
            primes[:25].append(j)
    print primes
else:
    for j in range(1,n+1):
        for i in range(0,len(primes[:25])):
            if j % primes[i] == 0:
                break
        else:
            primes[:25].append(j)
    print primes

end = time.time() - start
print end

我知道代码的工作时间是找到前1000个,而100万个质数却大不相同。
但是它仅打印不超过1000的质数,即不打印附加列表。我在哪里错了?

1 个答案:

答案 0 :(得分:1)

复制和更改代码以进行测试似乎是个坏主意,因为这两个版本会分开。相反,请修改初始条件并运行相同的代码:

import time

start = time.time()

n = 10000000

primes = [ \
    2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47, 53, 59, \
    61, 67, 71, 73, 79, 83, 89, 97, 101, 103, 107, 109, 113, 127, 131, 137, 139, \
    149, 151, 157, 163, 167, 173, 179, 181, 191, 193, 197, 199, 211, 223, 227, \
    229, 233, 239, 241, 251, 257, 263, 269, 271, 277, 281, 283, 293, 307, 311, \
    313, 317, 331, 337, 347, 349, 353, 359, 367, 373, 379, 383, 389, 397, 401, \
    409, 419, 421, 431, 433, 439, 443, 449, 457, 461, 463, 467, 479, 487, 491, \
    499, 503, 509, 521, 523, 541, 547, 557, 563, 569, 571, 577, 587, 593, 599, \
    601, 607, 613, 617, 619, 631, 641, 643, 647, 653, 659, 661, 673, 677, 683, \
    691, 701, 709, 719, 727, 733, 739, 743, 751, 757, 761, 769, 773, 787, 797, \
    809, 811, 821, 823, 827, 829, 839, 853, 857, 859, 863, 877, 881, 883, 887, \
    907, 911, 919, 929, 937, 941, 947, 953, 967, 971, 977, 983, 991, 997, \
]

# for testing:
n = 10000
primes = primes[:25]

for j in range(3, n + 1, 2):
    for prime in primes:
        if j % prime == 0:
            break  # skip composites and primes in list
    else:  # no break
        primes.append(j)

print primes

end = time.time() - start
print end

即使这不仅用于测试,也可以将其转换为有条件的:

if n <= 1000000:
     primes = primes[:25]

并且仍然避免代码重复。

  

我只是想在最短的时间内找到素数

如果是这种情况,难道您不应该只检查列表中的素数,直到j的平方根吗?当然,您还需要更改主列表管理逻辑。