我正在写一个俄罗斯方块克隆，这是我真正做过的最大的项目。在实现行删除代码时，我已经开始收到堆栈溢出异常。我认为这可能与我的大量收藏或Linq的低效率使用有关。以下是导致此问题的具体方法：
void MoveAllAboveDown(int row)
{
List<Block> newBlockList = new List<Block>();
for (int rowCheck = row; rowCheck > _VertOffset; --rowCheck)
{
for (int i = _HorizOffset; i < _HorizOffset + _Width; ++i)
{
//If the spot above this is filled
if (_blockList.Where(block => block.Contains(new Vector2(i, rowCheck - 1))).ToList().Count > 0)
{
//insert block here
newBlockList.Add(new Block(new Vector2(i, rowCheck), new[,] { { true } }, Color.Black, _texture));
}
else
{
var list = _blockList.Where(tempBlock => tempBlock.Contains(new Vector2(i, rowCheck - 1))).ToList();
if (list.Count > 0)
list.ElementAt(0).Delete(new Vector2(i, rowCheck - 1));
}
}
}
for (int rowToDelete = row; rowToDelete > _VertOffset; --rowToDelete)
{
DeleteRow(rowToDelete);
}
foreach (Block block in newBlockList)
{
_blockList.Add(block);
}
}
如果我能弄清楚如何（如果必须使用单独的网站），我会附上整个来源。
如果您愿意，我真的不介意是否有人要查看整个代码库并告诉我我写错了什么（比如命名约定，算法等）。显然这不是该网站的用途，但我认为自从我攻击代码库以来我就把它扔进去了。
编辑：
这是主要的游戏文件：
http://pastebin.com/PqVAS56U
这是代码的其余部分：
http://pastebin.com/JjBKZgwN
EDIT2： 我相信这是一个堆栈跟踪：
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_32\mscorlib\v4.0_4.0.0.0__b77a5c561934e089\mscorlib.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Users\Patrick\Desktop\OldComp\Users\patrick\Documents\Visual Studio 2010\Projects\Tetris\Tetris\Tetris\bin\x86\Debug\Tetris.exe', Symbols loaded.
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_32\Microsoft.Xna.Framework.Game\v4.0_4.0.0.0__842cf8be1de50553\Microsoft.Xna.Framework.Game.dll'
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_32\Microsoft.Xna.Framework.Graphics\v4.0_4.0.0.0__842cf8be1de50553\Microsoft.Xna.Framework.Graphics.dll'
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_32\Microsoft.Xna.Framework\v4.0_4.0.0.0__842cf8be1de50553\Microsoft.Xna.Framework.dll'
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\Microsoft.Xna.Framework.Input.Touch\v4.0_4.0.0.0__842cf8be1de50553\Microsoft.Xna.Framework.Input.Touch.dll'
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Drawing\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Drawing.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System\v4.0_4.0.0.0__b77a5c561934e089\System.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Windows.Forms\v4.0_4.0.0.0__b77a5c561934e089\System.Windows.Forms.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\Microsoft.Xna.Framework.GamerServices\v4.0_4.0.0.0__842cf8be1de50553\Microsoft.Xna.Framework.GamerServices.dll'
'Tetris.exe' (Managed (v4.0.30319)): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Core\v4.0_4.0.0.0__b77a5c561934e089\System.Core.dll', Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Process is terminated due to StackOverflowException.
The program '[7484] Tetris.exe: Managed (v4.0.30319)' has exited with code 0 (0x0).
答案 0 :(得分：5)
在没有跟踪其余代码的情况下，我怀疑部分代码是使用row代替rowToDelete：
for (int rowToDelete = row; rowToDelete > _VertOffset; --rowToDelete)
{
// DeleteRow(row); // Woops! Typo
DeleteRow(rowToDelete);
}
编辑：如果不存在，则可能在DeleteRow中。
答案 1 :(得分：3)
我没有看到您将row的值传递给MoveAllAboveDown()，然后传递给DeleteRow()。您的DeleteRow()功能再次使用相同的MoveAllAboveDown()号码呼叫row。
所以他们会继续互相呼叫直到StackOverflow。
答案 2 :(得分：3)
我认为你获得堆栈跟踪的原因是MoveAllAboveDown（int row）调用DeleteRow（int row）调用MoveAllAboveDown（int row）创建一个无限循环，如已经指出by cornerback84。
以下是其他一些提示：